Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464764 - sci-astronomy/celestia fails to compile with libpng-1.6
Summary: sci-astronomy/celestia fails to compile with libpng-1.6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Astronomy project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: libpng16
  Show dependency tree
 
Reported: 2013-04-05 17:32 UTC by Lars Wendler (Polynomial-C) (RETIRED)
Modified: 2013-04-15 16:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,38.94 KB, text/plain)
2013-04-05 17:32 UTC, Lars Wendler (Polynomial-C) (RETIRED) 		Details
celestia-1.6.1-libpng16_include_stringh.patch (celestia-1.6.1-libpng16_include_stringh.patch,464 bytes, patch)
2013-04-07 10:19 UTC, Lars Wendler (Polynomial-C) (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-04-05 17:32:55 UTC 
Created attachment 344536 [details]
build.log

x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../.. -I..   -DLUA_VER=0x050100 -DCELX  -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -march=barcelona -mtune=barcelona -O2 -pipe -finline-functions -fsigned-char -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -c -o libcelengine_a-image.o `test -f 'image.cpp' || echo './'`image.cpp
image.cpp:557:7: warning: "TARGET_OS_MAC" is not defined [-Wundef]
image.cpp: In function ‘Image* LoadJPEGImage(const string&, int)’:
image.cpp:530:61: error: ‘memcpy’ was not declared in this scope
image.cpp: In function ‘Image* LoadPNGImage(const string&)’:
image.cpp:658:41: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
image.cpp: In function ‘void PNGReadData(png_structp, png_bytep, png_size_t)’:
image.cpp:632:39: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
make[3]: *** [libcelengine_a-image.o] Error 1
make[3]: Leaving directory `/var/tmp/portage/sci-astronomy/celestia-1.6.1/work/celestia-1.6.1/src/celengine'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/sci-astronomy/celestia-1.6.1/work/celestia-1.6.1/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/sci-astronomy/celestia-1.6.1/work/celestia-1.6.1'
make: *** [all] Error 2
 * ERROR: sci-astronomy/celestia-1.6.1 failed (compile phase):
 *   emake failed
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2013-04-06 06:49:54 UTC 
right, #include <string.h> used to be implicit, but now it's not, just fixed this same bug in media-video/ffmpegthumbnailer/files/*memcpy*.patch
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-04-07 10:19:51 UTC 
Created attachment 344706 [details, diff]
celestia-1.6.1-libpng16_include_stringh.patch

Possible fix.
Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2013-04-07 13:46:20 UTC 
+*celestia-1.6.1-r1 (07 Apr 2013)
+
+  07 Apr 2013; Kacper Kowalik <xarthisius@gentoo.org> +celestia-1.6.1-r1.ebuild,
+  +files/celestia-1.6.1-libpng16.patch, -celestia-1.6.1.ebuild,
+  files/celestia-1.6.1-gcc46.patch:
+  Depend on autotools-1.11. Fixes #456370 by Diego Elio Pettenò
+  <flameeyes@gentoo.org> Fix building with libpng-1.6 wrt #464764 by Lars
+  Wendler <polynomial-c@gentoo.org>
+