Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 464336 - media-sound/mp3info-0.8.5a fails with sys-libs/ncurses[tinfo]
Summary: media-sound/mp3info-0.8.5a fails with sys-libs/ncurses[tinfo]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: tinfo
  Show dependency tree
 
Reported: 2013-04-03 12:13 UTC by Gary Macindoe
Modified: 2014-10-28 11:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for existing mp3info-0.8.5a.ebuild (mp3info-0.8.5a-ncurses.patch,305 bytes, text/plain)
2013-04-03 12:13 UTC, Gary Macindoe
Details
New ebuild (mp3info-0.8.5a-r1.ebuild,1.00 KB, text/plain)
2013-04-03 12:15 UTC, Gary Macindoe
Details
Fixed patch for existing mp3info-0.8.5a.ebuild as per comment 2 (mp3info-0.8.5a-ncurses.patch,314 bytes, patch)
2013-04-03 13:45 UTC, Gary Macindoe
Details | Diff
New ebuild (mp3info-0.8.5a-r1.ebuild,1.08 KB, text/plain)
2013-04-03 13:45 UTC, Gary Macindoe
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gary Macindoe 2013-04-03 12:13:36 UTC
Created attachment 344206 [details]
Patch for existing mp3info-0.8.5a.ebuild

media-sound/mp3info-0.8.5a has -lncurses hard-coded into the Makefile causing it to fail when libncurses is split into libncurses.so and libtinfo.so.  This happens when sys-libs/ncurses is emerged with the tinfo USE flag set.

A trivial solution is to use sed and pkg-config in src_prepare to change the LIBS variable to include -ltinfo when necessary.
Comment 1 Gary Macindoe 2013-04-03 12:15:35 UTC
Created attachment 344208 [details]
New ebuild
Comment 2 Samuli Suominen gentoo-dev 2013-04-03 13:19:41 UTC
pkg-config can't be called directly like that because it will override $PKG_CONFIG (and thus, $CHOST) and cause cross-compilers to fail

look at the /usr/portage/eclass/toolchain-funcs.eclass and the tc-getPKG_CONFIG function

inherit toolchain-funcs

$($(tc-getPKG_CONFIG) --libs-only-L ncurses)
Comment 3 Gary Macindoe 2013-04-03 13:45:02 UTC
Created attachment 344220 [details, diff]
Fixed patch for existing mp3info-0.8.5a.ebuild as per comment 2
Comment 4 Gary Macindoe 2013-04-03 13:45:26 UTC
Created attachment 344222 [details]
New ebuild
Comment 5 Jeroen Roovers gentoo-dev 2014-10-28 11:28:23 UTC
Fixed without revision bump.