Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 462066 - [request action from kernel teams] Change in Linux 3.6 and later kernels causes deadlock when using ZFS
Summary: [request action from kernel teams] Change in Linux 3.6 and later kernels caus...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal critical (vote)
Assignee: Richard Yao (RETIRED)
URL: https://github.com/zfsonlinux/zfs/iss...
Whiteboard:
Keywords: Bug, PATCH, REVIEWED
Depends on: 462220
Blocks:
  Show dependency tree
 
Reported: 2013-03-17 15:44 UTC by Richard Yao (RETIRED)
Modified: 2016-01-16 20:12 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to revert commits (patch,2.82 KB, patch)
2013-03-17 15:44 UTC, Richard Yao (RETIRED)
Details | Diff
Patch to revert commits (patch,2.82 KB, patch)
2013-03-17 17:13 UTC, Richard Yao (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Yao (RETIRED) gentoo-dev 2013-03-17 15:44:03 UTC
Created attachment 342386 [details, diff]
Patch to revert commits

Some changes to the memory management code during the Linux 3.6 development cycle can cause a deadlock regression in ZFS. The URL field has a link to the upstream issue that describes precisely why the deadlock occurs. I am working on a fix, but it will take 3 to 4 weeks at the minimum before it is ready. Would it be possible to revert the following commits in gentoo-sources and hardened-sources until I have a fix ready for the tree?

https://github.com/torvalds/linux/commit/c3b94f44fcb0725471ecebb701c077a0ed67bd07
https://github.com/torvalds/linux/commit/e62e384e9da8d9a0c599795464a7e76fd490931c

These patches only benefit kernels built with CONFIG_MEMCG (default N in Kconfig) when memory cgroups are actually used, are given small quantities of RAM and have significant disk IO occur in them. As far as I can tell, nothing in the main tree uses this and the one user on the forums that appears to use memory cgroups does not use them under conditions that would trigger the issue that these patches are meant to solve.
Comment 1 Richard Yao (RETIRED) gentoo-dev 2013-03-17 17:13:43 UTC
Created attachment 342410 [details, diff]
Patch to revert commits

There was a minor typo in the previous patch's comment that broke the upstream URL. I have attached a revised version that resolves it.
Comment 2 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-03-17 19:16:22 UTC
+  17 Mar 2013; Tom Wijsman <TomWij@gentoo.org> +gentoo-sources-3.2.40-r1.ebuild,
+  +gentoo-sources-3.6.11-r2.ebuild, +gentoo-sources-3.7.10-r1.ebuild,
+  +gentoo-sources-3.8.3-r1.ebuild, -gentoo-sources-3.0.67.ebuild,
+  -gentoo-sources-3.0.68.ebuild, -gentoo-sources-3.2.39.ebuild,
+  -gentoo-sources-3.2.40.ebuild, -gentoo-sources-3.4.35.ebuild,
+  -gentoo-sources-3.8.1.ebuild, -gentoo-sources-3.8.2.ebuild,
+  -gentoo-sources-3.8.3.ebuild:
+  Revision bumps for 3.2.40, 3.6.11, 3.7.10 and 3.8.3 and removal of
+  intermediate versions: Revert memcg patches that prevent OOM with too many
+  dirty pages which caused ZFS to flush dirty pages to deadlock, see bug
+  #462066; in 3.6, 3.7 and 3.8. Backported fixes from 3.8 to 3.7 that affect
+  some of our Gentoo users. Backported one of these patches to 3.2 as well since
+  there was no 3.2 bump last week.
Comment 3 Richard Yao (RETIRED) gentoo-dev 2016-01-16 20:12:12 UTC
This was resolved in sys-fs/zfs-kmod-0.6.4.