net-wireless/broadcom-sta-126.96.36.199-r2 fails to compile against sys-kernel/gentoo-sources-3.8.0 on my amd64 laptop:
CC [M] /var/tmp/portage/net-wireless/broadcom-sta-188.8.131.52-r2/work/src/wl/sys/wl_cfg80211.o
/var/tmp/portage/net-wireless/broadcom-sta-184.108.40.206-r2/work/src/wl/sys/wl_cfg80211.c: In function 'wl_cfg80211_join_ibss':
/var/tmp/portage/net-wireless/broadcom-sta-220.127.116.11-r2/work/src/wl/sys/wl_cfg80211.c:745:26: error: 'struct cfg80211_ibss_params' has no member named 'channel'
/var/tmp/portage/net-wireless/broadcom-sta-18.104.22.168-r2/work/src/wl/sys/wl_cfg80211.c: At top level:
/var/tmp/portage/net-wireless/broadcom-sta-22.214.171.124-r2/work/src/wl/sys/wl_cfg80211.c:1644:2: warning: initialization from incompatible pointer type [enabled by default]
/var/tmp/portage/net-wireless/broadcom-sta-126.96.36.199-r2/work/src/wl/sys/wl_cfg80211.c:1644:2: warning: (near initialization for 'wl_cfg80211_ops.scan') [enabled by default]
/var/tmp/portage/net-wireless/broadcom-sta-188.8.131.52-r2/work/src/wl/sys/wl_cfg80211.c:1649:2: warning: initialization from incompatible pointer type [enabled by default]
/var/tmp/portage/net-wireless/broadcom-sta-184.108.40.206-r2/work/src/wl/sys/wl_cfg80211.c:1649:2: warning: (near initialization for 'wl_cfg80211_ops.set_tx_power') [enabled by default]
/var/tmp/portage/net-wireless/broadcom-sta-220.127.116.11-r2/work/src/wl/sys/wl_cfg80211.c:1650:2: warning: initialization from incompatible pointer type [enabled by default]
/var/tmp/portage/net-wireless/broadcom-sta-18.104.22.168-r2/work/src/wl/sys/wl_cfg80211.c:1650:2: warning: (near initialization for 'wl_cfg80211_ops.get_tx_power') [enabled by default]
/var/tmp/portage/net-wireless/broadcom-sta-22.214.171.124-r2/work/src/wl/sys/wl_cfg80211.c: In function 'wl_update_bss_info':
/var/tmp/portage/net-wireless/broadcom-sta-126.96.36.199-r2/work/src/wl/sys/wl_cfg80211.c:2077:11: error: 'struct cfg80211_bss' has no member named 'information_elements'
/var/tmp/portage/net-wireless/broadcom-sta-188.8.131.52-r2/work/src/wl/sys/wl_cfg80211.c:2078:15: error: 'struct cfg80211_bss' has no member named 'len_information_elements'
Full emerge log and possible patch to be attached
Created attachment 340112 [details]
Created attachment 340114 [details, diff]
This package currently has no maintainer, it may take some time for this package to be fixed; probably once a developer that uses broadcom-sta switches to 3.8.0 and experiences this as well.
> possible patch
Hmm, did you just found this or did you try it and confirmed whether it works?
>> possible patch
> Hmm, did you just found this or did you try it and confirmed whether it works?
I've just fixed compilation errors and added old patch to fix kernel panic in wl_cfg80211_scan.
Works for me.
What complementary patch are you applying also? Is there a bug for that panic issue?
Actually I don't remember where I did get this wl_cfg80211_scan patch from.
It seems there are no gentoo bug.
What I can google for (by "wl_cfg80211_scan kernel panic") is https://bugzilla.rpmfusion.org/show_bug.cgi?id=2526 describing the issue and having exactly the same patch I used to apply (see "Patch fixing the issue" attachement). The only difference is that I've added
#if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 6, 0)
Double-checked the patch attached, it is missing '#ifdef' for linux version in functions. Can provide new one if someone needs it to work with kernel<3.8.0 (which I doubt:))
It's much better to make it work with as much kernel versions as possible as it's a bit difficult to ensure people will build AND RUN it on desired kernel
Created attachment 340682 [details, diff]
Added '#ifdef' to support pre-3.8 kernels
This might be a good time to add epatch_user to make these issues a bit easier for end-users to apply workarounds until the maintainer has time to find/add the proper backwards-compatible patches.
+ 08 Mar 2013; Sergey Popov <email@example.com>
+ Add epatch_user, as suggested by Ben Kohler in bug #459208
I confirm that patch in attachment 340682 [details, diff] works for me, thanks
Gentoo (amd64) on Acer Aspire 5755G
(In reply to comment #9)
> Created attachment 340682 [details, diff] [details, diff]
> Added '#ifdef' to support pre-3.8 kernels
I don't mean to look a gift horse in the mouth, but can you please separate these patches into 1 for the scan fix and 1 for the 3.8 build fix? I'll get this moved into the tree if you do.
If you make changes to this ebuild, you could consider this one.
If you make any changes to this package you could consider this one too.
Now even compiles against 3.9.0. Weeeeeeeeee!
Thanks for reporting it.
It should hit upstream as soon as a dev commits it. Please refer to #438622 for further details.
Until then, get them from my overlay; tbc in layman.
As stated above, if someone has split the patch I'll be happy to commit it...
broadcom-sta-184.108.40.206-linux-3.8.patch in bug #468388 contains the sole fix for making it work with 3.8.
That's great, now what about the extra functionality described in https://bugs.gentoo.org/show_bug.cgi?id=459208#c6 ?
included in the same bug as net-wireless/broadcom-sta-220.127.116.11-linux-3.6.patch.
(In reply to comment #20)
> included in the same bug as
Yes, and that's why I'm not accepting it. Please reread comment 13.
The patch is already in the tree, so this report can be closed
(In reply to MJJoker from comment #22)
> The patch is already in the tree, so this report can be closed