Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 458446 - app-accessibility/rhvoice-1.0 - Free and open source speech synthesizer for Russian language
Summary: app-accessibility/rhvoice-1.0 - Free and open source speech synthesizer for R...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Default Assignee for New Packages
URL: https://github.com/Olga-Yakovleva/RHV...
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2013-02-20 12:26 UTC by RedEyedMan
Modified: 2022-04-11 08:55 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
app-accessibility/rhvoice-1.0.ebuild (rhvoice-1.0.ebuild,824 bytes, text/plain)
2013-02-20 12:26 UTC, RedEyedMan
Details
app-accessibility/rhvoice/rhvoice-1.0.ebuild (rhvoice-1.0.ebuild,845 bytes, text/plain)
2013-02-20 12:38 UTC, RedEyedMan
Details
app-accessibility/rhvoice/rhvoice-1.0.ebuild (rhvoice-1.0.ebuild,934 bytes, text/plain)
2013-02-21 21:56 UTC, RedEyedMan
Details
339642: app-accessibility/rhvoice/rhvoice-.0.2.ebuild (rhvoice-0.2.ebuild,997 bytes, text/plain)
2013-02-22 22:41 UTC, RedEyedMan
Details
app-accessibility/rhvoice/rhvoice-.0.2.ebuild (rhvoice-0.2.ebuild,998 bytes, text/plain)
2013-02-22 22:53 UTC, RedEyedMan
Details
live ebuild (rhvoice-9999.ebuild,810 bytes, text/plain)
2013-02-27 19:06 UTC, Dmitri Bogomolov
Details
live ebuild (rhvoice-9999.ebuild,711 bytes, text/plain)
2013-02-27 20:42 UTC, Dmitri Bogomolov
Details
app-accessibility/rhvoice/rhvoice-0.3_p20121116.ebuild (rhvoice-0.3_p20121116.ebuild,1.05 KB, text/plain)
2014-06-26 14:55 UTC, Andrey
Details
app-accessibility/rhvoice/files/rhvoice-0.3-custom-cc.patch (rhvoice-0.3-custom-cc.patch,683 bytes, patch)
2014-06-26 14:57 UTC, Andrey
Details | Diff
ebuild for media-libs/libsonic (libsonic-0.1.18.ebuild,462 bytes, text/plain)
2014-07-19 10:06 UTC, Dmitri Bogomolov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description RedEyedMan 2013-02-20 12:26:34 UTC
Created attachment 339492 [details]
app-accessibility/rhvoice-1.0.ebuild

Description:         Free and open source speech synthesizer for Russian language
Homepage:            https://github.com/Olga-Yakovleva/RHVoice

Hi! I created this ebuild from scratch and I would like to become a maintainer of that package.  Thanks :)
Comment 1 RedEyedMan 2013-02-20 12:38:33 UTC
Created attachment 339496 [details]
app-accessibility/rhvoice/rhvoice-1.0.ebuild

Description and depends are updated.
Comment 2 Sergey Popov (RETIRED) gentoo-dev 2013-02-20 23:05:44 UTC
(In reply to comment #1)
> Created attachment 339496 [details]
> app-accessibility/rhvoice/rhvoice-1.0.ebuild
> 
> Description and depends are updated.

Some notes for ebuild:

- Use latest EAPI if it's possible(it is EAPI=5 now)
- Utilize scons-utils eclass and apropriate functions from it for scons-based package
- Dependencies on scons and gcc can be omitted(scons dependency can be added automatically through scons-utils eclass)
- For python handling - use python-r1 eclass
- We prefer ebuild of releases unless changes in current git sources are vitally needed. If yes, then we make snapshot ebuilds

Please fix above issues(for the last one - just tell why git sources are preferrable).
Comment 3 RedEyedMan 2013-02-21 20:48:44 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Created attachment 339496 [details]
> > app-accessibility/rhvoice/rhvoice-1.0.ebuild
> > 
> > Description and depends are updated.
> 
> Some notes for ebuild:
> 
> - Use latest EAPI if it's possible(it is EAPI=5 now)
> - Utilize scons-utils eclass and apropriate functions from it for
> scons-based package
> - Dependencies on scons and gcc can be omitted(scons dependency can be added
> automatically through scons-utils eclass)
> - For python handling - use python-r1 eclass
> - We prefer ebuild of releases unless changes in current git sources are
> vitally needed. If yes, then we make snapshot ebuilds
> 
> Please fix above issues(for the last one - just tell why git sources are
> preferrable).

Ok :)
I found it only on git.
Comment 4 RedEyedMan 2013-02-21 21:56:15 UTC
Created attachment 339642 [details]
app-accessibility/rhvoice/rhvoice-1.0.ebuild

Failed while generating the manifest with error 'PYTHON_COMPAT not declared' if I use python-r1.eclass, but there is already PYTHON_COMPAT=( python{2_7} )

What wrong I do ?
Comment 5 RedEyedMan 2013-02-21 22:15:15 UTC
Where I should place snapshot from git if git is not preferrable?
Comment 6 William Hubbs gentoo-dev 2013-02-21 22:34:55 UTC
If you look at the README in the source tree, it tells you where to
download the latest release from; that is where the ebuild should get
the tarball. Also, based on the tags I saw in the source repository, 0.2
is the latest release, not 1.0.

Thanks,

William
Comment 7 RedEyedMan 2013-02-21 23:09:32 UTC
(In reply to comment #6)
> If you look at the README in the source tree, it tells you where to
> download the latest release from; that is where the ebuild should get
> the tarball. Also, based on the tags I saw in the source repository, 0.2
> is the latest release, not 1.0.
> 
> Thanks,
> 
> William

I looked to https://github.com/Olga-Yakovleva/RHVoice/downloads but there is only 

 RHVoice-NVDA-synthDriver-v0.2.7z — NVDA synthDriver which is uploaded 2 years ago. There is no tarbail related to RHVoice, or am I mistaken? I can clone it from git and create tarbail manually. Is it preferrable?
Comment 8 Sergey Popov (RETIRED) gentoo-dev 2013-02-22 13:00:38 UTC
(In reply to comment #4)
> Created attachment 339642 [details]
> app-accessibility/rhvoice/rhvoice-1.0.ebuild
> 
> Failed while generating the manifest with error 'PYTHON_COMPAT not declared'
> if I use python-r1.eclass, but there is already PYTHON_COMPAT=( python{2_7} )
> 
> What wrong I do ?

Look at the documentation - http://wiki.gentoo.org/wiki/Python-r1/examples
You should define PYTHON_COMPAT before inheriting python-r1 or distutils-r1 eclasses
Comment 9 RedEyedMan 2013-02-22 15:20:50 UTC
(In reply to comment #8)
> (In reply to comment #4)
> > Created attachment 339642 [details]
> > app-accessibility/rhvoice/rhvoice-1.0.ebuild
> > 
> > Failed while generating the manifest with error 'PYTHON_COMPAT not declared'
> > if I use python-r1.eclass, but there is already PYTHON_COMPAT=( python{2_7} )
> > 
> > What wrong I do ?
> 
> Look at the documentation - http://wiki.gentoo.org/wiki/Python-r1/examples
> You should define PYTHON_COMPAT before inheriting python-r1 or distutils-r1
> eclasses

Thanks, I didn't know about it, because I looked only at http://devmanual.gentoo.org/eclass-reference/python-r1.eclass/index.html
where is no any note about define PYTHON_COMPAT before inherit.
Comment 10 William Hubbs gentoo-dev 2013-02-22 18:05:23 UTC
Please leave the severity as "enhancement"; this is the severity we use for
new packages.
Comment 11 William Hubbs gentoo-dev 2013-02-22 18:11:00 UTC
(In reply to comment #7)
> I looked to https://github.com/Olga-Yakovleva/RHVoice/downloads but there is
> only 
> 
>  RHVoice-NVDA-synthDriver-v0.2.7z — NVDA synthDriver which is uploaded 2
> years ago. There is no tarbail related to RHVoice, or am I mistaken? I can
> clone it from git and create tarbail manually. Is it preferrable?

Since it is on github, you may be able to  inherit the vcs-snapshot eclass and not create a tarball.
Comment 12 William Hubbs gentoo-dev 2013-02-22 21:48:46 UTC
Also, the dependencies in your ebuild do not look
right, DEPEND=${RDEPEND}"..." appears to be a typo.
Comment 13 RedEyedMan 2013-02-22 22:41:06 UTC
Created attachment 339760 [details]
339642: app-accessibility/rhvoice/rhvoice-.0.2.ebuild


I found tarbail on https://nodeload.github.com/Olga-Yakovleva/RHVoice/legacy.tar.gz/0.2


* Ebuild fixed and version renamed from 1.0 to 0.2.
Comment 14 RedEyedMan 2013-02-22 22:53:36 UTC
Created attachment 339762 [details]
app-accessibility/rhvoice/rhvoice-.0.2.ebuild

 * DEPEND=${RDEPEND}" changed to DEPEND="${RDEPEND}"
Comment 15 Dmitri Bogomolov 2013-02-27 19:06:56 UTC
Created attachment 340406 [details]
live ebuild
Comment 16 RedEyedMan 2013-02-27 19:14:49 UTC
(In reply to comment #15)
> Created attachment 340406 [details]
> live ebuild

Why here multilib !? Why you used dirty hack? Look at git of rhvoice. There is no neither about multilib. 

Look to recommendations above which given for me and use them too.
Comment 17 Dmitri Bogomolov 2013-02-27 20:42:28 UTC
Created attachment 340410 [details]
live ebuild

Cleanup.
Comment 18 Dmitri Bogomolov 2013-02-27 20:56:24 UTC
(In reply to comment #16)
> (In reply to comment #15)
> > Created attachment 340406 [details]
> > live ebuild
> 
> Why here multilib !? Why you used dirty hack?

Because it was here when I found this ebuild on githab.
Without SCONSOPTS="" escons dies. I just tried.

> Look to recommendations above which given for me and use them too.

I use: no need for EAPI=5. This ebuild don't install python modules. There is a live ebuild, so EGIT_REPO_URI=... I think the latest version from git is _vitally needed_ in case of RHVoice.
Comment 19 Andrey 2014-06-26 14:55:11 UTC
Created attachment 379732 [details]
app-accessibility/rhvoice/rhvoice-0.3_p20121116.ebuild

Yet another attempt to write a ebuild for rhvoice.
There is no actual 0.3 release, so this is just a git snapshot.
"0.3" is mentioned in SConstruct as "package_version".
The snapshot is taken from the git "master" branch, while development for 0.4 version is ongoing in the "rewrite" branch.

It seems, that "rewrite" branch doesn't currently have simple command-line text-to-speech tool, so I stick to (relatively old) "master" branch.

The ebuild correctly passes {C,LD}FLAGS, CC/CXX and libdir.
It requires the following rhvoice-0.3-custom-cc.patch.
Comment 20 Andrey 2014-06-26 14:57:16 UTC
Created attachment 379734 [details, diff]
app-accessibility/rhvoice/files/rhvoice-0.3-custom-cc.patch

Patch to RHVoice to allow setting custom C/C++ compilers, required for rhvoice-0.3_p20121116.ebuild.
Comment 21 Dmitri Bogomolov 2014-07-19 10:06:01 UTC
Created attachment 381042 [details]
ebuild for media-libs/libsonic

rhvoice also use libsonic in certain conditions
Comment 22 Dmitri Bogomolov 2014-07-19 10:36:19 UTC
It's interesting solution with tarball. You can also use short commit label "3e31edced4".
Comment 23 Andrey 2014-07-20 18:18:48 UTC
(In reply to Dmitri Bogomolov from comment #21)
> Created attachment 381042 [details]
> ebuild for media-libs/libsonic
> 
> rhvoice also use libsonic in certain conditions
As far as I can see, RHVoice bundles its own copy of the libsonic library.
The bundled copy is at src/lib/sonic.{c,h} on "master" branch and at src/third-party/sonic on "rewrite" branch.
So we either should 1) drop the libsonic ebuild or 2) keep the libsonic ebuild, add RHVoice dependency on libsonic to the RHVoice ebuild and patch RHVoice for it to be able to pick up the system-wide libsonic.

(In reply to Dmitri Bogomolov from comment #22)
> It's interesting solution with tarball. You can also use short commit label
> "3e31edced4".
Thank you, but it's not mine -- it was suggested here.:)
Thank you for the idea, but abbreviated hashes are much more likely to collide than full hashes.