Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 457652 - media-video/mplayer-1.1 - fix building against >=media-libs/giflib-5
Summary: media-video/mplayer-1.1 - fix building against >=media-libs/giflib-5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: giflib-5
  Show dependency tree
 
Reported: 2013-02-15 05:35 UTC by Andrew John Hughes
Modified: 2013-07-29 20:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixed ebuild which forces gif on when giflib >= 5 is used (mplayer-1.1-r1.ebuild,18.33 KB, text/plain)
2013-02-15 05:37 UTC, Andrew John Hughes
Details
Patch for mplayer when it does attempt to build with giflib 5 (mplayer-1.1-giflib5.patch,5.57 KB, patch)
2013-02-15 05:38 UTC, Andrew John Hughes
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew John Hughes 2013-02-15 05:35:57 UTC
configure will fail to pick up giflib 5 and, because the ebuild does not force it, mplayer will build but without gif support.

Reproducible: Always
Comment 1 Andrew John Hughes 2013-02-15 05:37:24 UTC
Created attachment 338948 [details]
Fixed ebuild which forces gif on when giflib >= 5 is used

This is necessary as the test fails due to gif_lib.h now requiring sys/types.h as a prerequisite, which the mplayer test doesn't allow for.
Comment 2 Andrew John Hughes 2013-02-15 05:38:20 UTC
Created attachment 338950 [details, diff]
Patch for mplayer when it does attempt to build with giflib 5
Comment 3 Alexis Ballier gentoo-dev 2013-02-15 16:01:14 UTC
is this patch from upstream  ?
Comment 4 Andrew John Hughes 2013-02-17 19:12:01 UTC
No, I wrote it.
Comment 5 Alexis Ballier gentoo-dev 2013-02-18 15:14:07 UTC
(In reply to comment #4)
> No, I wrote it.

could you please post it to mplayer-dev-eng so that it can be reviewed and i can include it?
Comment 7 Alexis Ballier gentoo-dev 2013-07-29 20:21:02 UTC
------------------------------------------------------------------------
r36367 | al | 2013-07-27 17:16:06 -0400 (Sat, 27 Jul 2013) | 24 lines

Support newer GIFLIB versions

Work with GIFLIB version >= 4.2




from mplayer svn log: it should be fixed in -9999