Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 457596 - app-doc/devmanual: some messages would be shown only in some cases
Summary: app-doc/devmanual: some messages would be shown only in some cases
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Markos Chandras (RETIRED)
URL:
Whiteboard:
Keywords: PATCH, REVIEWED
Depends on:
Blocks: first-time-messages
  Show dependency tree
 
Reported: 2013-02-14 19:32 UTC by Pacho Ramos
Modified: 2013-02-15 18:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
1.patch (1.patch,1.36 KB, patch)
2013-02-14 20:41 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2013-02-14 19:32:24 UTC
Not sure about the need on showing:
        elog
        elog "In order to browse the Gentoo Development Guide in"
        elog "offline mode, point your browser to the following url:"
        elog "/usr/share/doc/devmanual-9999/html/index.html"

always, probably it could be shown only first time the package is installed (using readme.gentoo.eclass).

Also:
        elog "The offline version of the devmanual does not include the"
        elog "documentation for the eclasses. If you need it, then emerge"
        elog "the following package:"
        elog
        elog "app-portage/eclass-manpages"

Could be shown only when that package is missing. 

I can commit the changes if you let me do :) (and also review your maintained packages if you want)

Reproducible: Always
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2013-02-14 20:21:55 UTC
I am not sure how to use this eclass yet. What I would do is to use $REPLACING_VERSIONS but I am willing to see an example of how this eclass could be used in this case.

Could you show me a patch? :)
Comment 2 Pacho Ramos gentoo-dev 2013-02-14 20:41:51 UTC
Created attachment 338900 [details, diff]
1.patch

This works fine for me
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2013-02-14 20:53:54 UTC
(In reply to comment #2)
> Created attachment 338900 [details, diff] [details, diff]
> 1.patch
> 
> This works fine for me

looks good to me. Feel free to commit it (and you can fix my packages that suffer from the same problem if you want to). Thanks!
Comment 4 Pacho Ramos gentoo-dev 2013-02-14 21:14:40 UTC
+  14 Feb 2013; Pacho Ramos <pacho@gentoo.org> devmanual-9999.ebuild:
+  Don't show elog messages always (#457596)
+
Comment 5 Pacho Ramos gentoo-dev 2013-02-15 18:04:07 UTC
I am reviewing other packages, but phpvirtualbox looks to not be able to use eapi >= 4:
>>> Emerging (1 of 1) app-emulation/phpvirtualbox-4.2.4
 * phpvirtualbox-4.2-4.zip SHA256 SHA512 WHIRLPOOL size ;-) ...                                                                                                  [ ok ]
>>> Unpacking source...
>>> Unpacking phpvirtualbox-4.2-4.zip to /var/tmp/portage/app-emulation/phpvirtualbox-4.2.4/work
>>> Source unpacked in /var/tmp/portage/app-emulation/phpvirtualbox-4.2.4/work
 * ERROR: app-emulation/phpvirtualbox-4.2.4 failed (prepare phase):
 *   The source directory '/var/tmp/portage/app-emulation/phpvirtualbox-4.2.4/work/phpvirtualbox-4.2.4' doesn't exist
 * 
 * Call stack:
 *            ebuild.sh, line 720:  Called __ebuild_main 'prepare'
 *   phase-functions.sh, line 942:  Called __dyn_prepare
 *   phase-functions.sh, line 367:  Called die
 * The specific snippet of code:
 *   		die "The source directory '${S}' doesn't exist"
 * 
 * If you need support, post the output of `emerge --info '=app-emulation/phpvirtualbox-4.2.4'`,
 * the complete build log and the output of `emerge -pqv '=app-emulation/phpvirtualbox-4.2.4'`.
 * The complete build log is located at '/var/log/portage/build/app-emulation/phpvirtualbox-4.2.4:20130215-180135.log'.
 * For convenience, a symlink to the build log is located at '/var/tmp/portage/app-emulation/phpvirtualbox-4.2.4/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/app-emulation/phpvirtualbox-4.2.4/temp/environment'.
 * Working directory: '/var/tmp/portage/app-emulation/phpvirtualbox-4.2.4'
 * S: '/var/tmp/portage/app-emulation/phpvirtualbox-4.2.4/work/phpvirtualbox-4.2.4'

Not sure why :S
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2013-02-15 18:13:31 UTC
Please open separate bugs as I will forget about this