Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 457082 - virtual/linux-sources-1 keywording request, please keyword sys-kernel/linux-firmware or mask USE="firmware"
Summary: virtual/linux-sources-1 keywording request, please keyword sys-kernel/linux-f...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Anthony Basile
URL: http://thread.gmane.org/gmane.linux.g...
Whiteboard:
Keywords: KEYWORDREQ
Depends on:
Blocks:
 
Reported: 2013-02-13 13:37 UTC by Chí-Thanh Christopher Nguyễn
Modified: 2014-04-15 10:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chí-Thanh Christopher Nguyễn gentoo-dev 2013-02-13 13:37:35 UTC 
In the firmware discussion on -dev mailing list, it was suggested to add a "firmware" USE-flag to virtual/linux-sources that triggers a dependency on sys-kernel/linux-firmware.

Whether to enable it by default or not (or in the desktop profile) would be your call.
Comment 1 Anthony Basile gentoo-dev 2013-02-14 01:27:18 UTC 
I didn't follow that discussion.  What you're asking is pretty straight forward.  Would the following suffice:


--- linux-sources-0.ebuild.orig	2013-02-13 20:24:33.000000000 -0500
+++ linux-sources-0.ebuild	2013-02-13 20:25:34.000000000 -0500
@@ -11,9 +11,9 @@
 LICENSE=""
 SLOT="0"
 KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86"
-IUSE=""
+IUSE="firmware"
 
-DEPEND=""
+DEPEND="firmware? ( sys-kernel/linux-firmware )"
 RDEPEND="|| (
 		sys-kernel/gentoo-sources
 		sys-kernel/vanilla-sources
Comment 2 Chí-Thanh Christopher Nguyễn gentoo-dev 2013-02-14 11:50:18 UTC 
Yes, that would work.
Comment 3 Anthony Basile gentoo-dev 2013-02-14 13:23:31 UTC 
(In reply to comment #2)
> Yes, that would work.

Okay I just noticed that sys-kernel/linux-firmware is not keyworded for all arches while virtual/linux-sources is:

1) For sys-kernel/linux-firmware we have at least one version stable on amd64, arm and x86.  And we only have ~ia64.  No other keyworded arches.

2) For virtual/linux-sources-0 we have

   KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 s390 sh sparc x86"


So,

1) The following arches either mask or keyword sys-kernel/linux-firmware:

    alpha hppa mips ppc ppc64 s390 sh sparc"

2) I will add virtual/linux-sources-1 to the tree with KEYWORD="~amd64 ~arm ~ia64 ~x86" and as the arches keyword/mask sys-kernel/linux-firmware on their arches, just expand the KEYWORD list.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2013-02-14 14:30:16 UTC 
HPPA is up to the keywording level of the other stable arches.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2013-02-14 15:23:04 UTC 
Marked ~hppa.
Comment 6 Matt Turner gentoo-dev 2013-05-11 01:14:30 UTC 
Added ~alpha and ~mips.
Comment 7 Anthony Basile gentoo-dev 2013-05-14 21:07:28 UTC 
Keyworded ~ppc ~ppc64.
Comment 8 Anthony Basile gentoo-dev 2013-06-18 01:03:47 UTC 
Ping s390, sh and sparc.