Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 455070 - media-libs/freetype: please review/prepare a multilib-build conversion
Summary: media-libs/freetype: please review/prepare a multilib-build conversion
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Fonts Team
URL:
Whiteboard:
Keywords:
Depends on: 454646 457134
Blocks: 455066 455074
  Show dependency tree
 
Reported: 2013-02-01 23:49 UTC by Michał Górny
Modified: 2013-10-09 22:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Working multilib ebuild (freetype-2.4.11.ebuild,4.16 KB, text/plain)
2013-02-01 23:49 UTC, Michał Górny
Details
Diff against gx86 one (freetype-2.4.11.ebuild.diff,1.78 KB, patch)
2013-02-01 23:50 UTC, Michał Górny
Details | Diff
Ebuild, r2 (freetype-2.4.11.ebuild,4.31 KB, text/plain)
2013-02-02 19:27 UTC, Michał Górny
Details
Diff for r2 (freetype-2.4.11.ebuild.diff,2.17 KB, patch)
2013-02-02 19:27 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-01 23:49:56 UTC
Created attachment 337630 [details]
Working multilib ebuild

As media-libs/freetype is a part of emul-linux-x86-xlibs, I have prepared a conversion of it along with the X11 packages. I will attach a complete ebuild and a diff.

Functional changes:

1) includes are installed to libdir. This was necessary to split the ABI-dependant configs (bug 254646) but it won't hurt packages using pkg-config;

2) removed epunt_cxx (a no-op here),

3) added a blocker on current emul-linux-x86-xlibs versions (to fix collisions),

4) converted the package to autotools-multilib.

I know that Samuli is autotools-* eclass hater, so he'd probably want to reinvent all the wheels. Feel free to do so.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-01 23:50:24 UTC
Created attachment 337632 [details, diff]
Diff against gx86 one
Comment 2 Ben de Groot (RETIRED) gentoo-dev 2013-02-02 08:10:54 UTC
I don't think this is quite ready for prime-time yet. Let's test this in x11 overlay for a while, and in the meantime see where the dev ML discussion is going.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-02 10:09:02 UTC
(In reply to comment #2)
> I don't think this is quite ready for prime-time yet. Let's test this in x11
> overlay for a while, and in the meantime see where the dev ML discussion is
> going.

I agree. I am mostly asking for general/code feedback on non-X11 packages so that at least a few checkboxes could be crossed.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-02 11:27:04 UTC
It should be noted that it doesn't work on a clean system ;). Setting another includedir breaks freetype-config (and yes, we should finally remove it/replace with pkg-config), and that breaks fontconfig build. Ancient compatibility mess...
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-02 19:27:42 UTC
Created attachment 337698 [details]
Ebuild, r2

(now with work-around for bug 455114)
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-02 19:27:58 UTC
Created attachment 337700 [details, diff]
Diff for r2
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-22 09:31:06 UTC
Since there's a few users of multilib-build in the tree, we'd like to proceed deploying X11 libraries from emul-linux-x86-xlibs to the tree. Since freetype is part of that set, I'd appreciate your +1/-1 ASAP so we would know whether to keep the two in emul-linux or convert as well.
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-25 22:37:05 UTC
Committed.
Comment 9 Ryan Hill (RETIRED) gentoo-dev 2013-02-26 05:02:48 UTC
You broke USE=utils.

 * Building utils
make -j10 V=1 X11_PATH=/usr/lib64 
../freetype-2.4.11/config.mk:25: ../freetype-2.4.11/builds/unix/unix-def.mk: No such file or directory
../freetype-2.4.11/config.mk:26: ../freetype-2.4.11/builds/unix/unix-cc.mk: No such file or directory
make: *** No rule to make target `../freetype-2.4.11/builds/unix/unix-cc.mk'.  Stop.
Comment 10 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-26 07:17:41 UTC
(In reply to comment #9)
> You broke USE=utils.

Oh, I'm sorry. I won't be able to fix it in next ~8 hours, so I'll package.mask the new versions for a while.
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-26 14:40:56 UTC
Took me a while but fixed them finally. I've also opened a bug upstream [1] asking them to make it easier, or at least a bit more consistent.

[1]:https://savannah.nongnu.org/bugs/?38412
Comment 12 Ben de Groot (RETIRED) gentoo-dev 2013-04-05 14:03:04 UTC
(In reply to comment #7)
> Since there's a few users of multilib-build in the tree, we'd like to
> proceed deploying X11 libraries from emul-linux-x86-xlibs to the tree. Since
> freetype is part of that set, I'd appreciate your +1/-1 ASAP so we would
> know whether to keep the two in emul-linux or convert as well.

You already had my -1 in comment #2. You pushed it through regardless, with ack by lu_zero who hasn't touched the package in 8 years. Since you broke a lot of packages doing so, as I feared, I have masked your ebuild. But I still am of the opinion that this should be developed and tested in an overlay instead of the tree.

Before considering unmasking this, we need to decide as a developer community that this is indeed the way we want to go. As I see it now, it has its problems.
Comment 13 Dyweni 2013-10-09 22:35:12 UTC
*** Bug 487472 has been marked as a duplicate of this bug. ***