Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 454594 - app-admin/collectd-5.2.1 version bump
Summary: app-admin/collectd-5.2.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Proxy Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 458386
  Show dependency tree
 
Reported: 2013-01-29 21:44 UTC by Johan Bergström
Modified: 2013-03-06 17:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
collectd-5.2.1.ebuild (collectd-5.2.1.ebuild,12.67 KB, text/plain)
2013-03-04 01:26 UTC, Johan Bergström
Details
build.log from building collectd without perl (build.log,8.93 KB, text/plain)
2013-03-06 09:44 UTC, Thomas Deutschmann (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Bergström 2013-01-29 21:44:16 UTC
New version out 5 days ago. I'll take care of bringing the ebuild up to date since we need to re-bake the perl patch. Just wanted to create a placeholder bug so others don't have to.
Comment 1 Johan Bergström 2013-03-04 01:26:27 UTC
Created attachment 340900 [details]
collectd-5.2.1.ebuild

Here's an updated ebuild. Commitdiff here: https://github.com/jbergstroem/gentoo-overlay/compare/collectd-5.2.1

(I also removed the rm *.a line since there was no files to remove.)
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2013-03-05 21:27:20 UTC
+*collectd-5.2.1 (05 Mar 2013)
+
+  05 Mar 2013; Markos Chandras <hwoarang@gentoo.org> +collectd-5.2.1.ebuild:
+  Version bump. #454594. Thanks to Johan Bergström <bugs@bergstroem.nu>
+
Comment 3 Johan Bergström 2013-03-06 03:24:04 UTC
It seems like building without perl can bail in some setups (found this just now) during the configure phase. Sorry for not finding it in time, Markos.

Here's a diff that fixes is:
--- /usr/portage/app-admin/collectd/collectd-5.2.1.ebuild	2013-03-06 08:26:50.000000000 +1100
+++ collectd-5.2.1.ebuild	2013-03-06 14:20:26.728959748 +1100
@@ -289,7 +289,11 @@
 	fi

 	# The perl bindings
-	myconf+=" $(use_with perl perl-bindings=INSTALLDIRS=vendor)"
+	if use perl; then
+		myconf+=" --with-perl-bindings=INSTALLDIRS=vendor"
+	else
+		myconf+=" --without-perl-bindings"
+	fi

 	# Finally, run econf.
 	KERNEL_DIR="${KERNEL_DIR}" econf --config-cache --without-included-ltdl $(use_enable static-libs static) --localstatedir=/var ${myconf}


Do you think we should -r1?
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2013-03-06 09:44:52 UTC
Created attachment 341090 [details]
build.log from building collectd without perl

(In reply to comment #3)
> Do you think we should -r1?

Would be nice (at least update the ebuild) - I am affected by this problem:

configure: error: invalid package name: perl-bindings=INSTALLDIRS=vendor
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2013-03-06 09:47:56 UTC
(In reply to comment #3)
> It seems like building without perl can bail in some setups (found this just
> now) during the configure phase. Sorry for not finding it in time, Markos.
> 
> Here's a diff that fixes is:
> --- /usr/portage/app-admin/collectd/collectd-5.2.1.ebuild	2013-03-06
> 08:26:50.000000000 +1100
> +++ collectd-5.2.1.ebuild	2013-03-06 14:20:26.728959748 +1100
> @@ -289,7 +289,11 @@
>  	fi
> 
>  	# The perl bindings
> -	myconf+=" $(use_with perl perl-bindings=INSTALLDIRS=vendor)"
> +	if use perl; then
> +		myconf+=" --with-perl-bindings=INSTALLDIRS=vendor"
> +	else
> +		myconf+=" --without-perl-bindings"
> +	fi
> 
>  	# Finally, run econf.
>  	KERNEL_DIR="${KERNEL_DIR}" econf --config-cache --without-included-ltdl
> $(use_enable static-libs static) --localstatedir=/var ${myconf}
> 
> 
> Do you think we should -r1?

No need for -r1. I presume those who hit this problem will not be able to configure/build the package. I will update the ebuild tonight.
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2013-03-06 17:50:10 UTC
+  06 Mar 2013; Markos Chandras <hwoarang@gentoo.org> collectd-5.2.1.ebuild:
+  Fix building without perl
+