452544 – Old vlan flags syntax isn't handled correctly

Bug 452544 - Old vlan flags syntax isn't handled correctly

Summary: Old vlan flags syntax isn't handled correctly

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Hosted Projects
Classification:	Unclassified
Component:	OpenRC (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	OpenRC Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	439098
	Show dependency tree

Reported:	2013-01-16 12:49 UTC by vitalyb
Modified:	2013-02-17 21:42 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description vitalyb 2013-01-16 12:49:27 UTC

Hello,

there's a typo in net/vlan.sh script which breaks backward compatibility for vlan flags:

--- vlan.sh.orig	2013-01-03 10:28:39.000000000 +0200
+++ vlan.sh	2013-01-16 14:44:51.000000000 +0200
@@ -71,7 +71,7 @@
 		[ -z "${vname}" ] && vname="${IFACE}.${vlan}"
 		# 2) flags
 		eval vflags=\$${IFACE}_vlan${vlan}_flags
-		[ -z "${vname}" ] && eval vflags=\$vlan${vlan}_flags
+		[ -z "${vflags}" ] && eval vflags=\$vlan${vlan}_flags
 		# 3) ingress/egress map
 		eval vingress=\$${IFACE}_vlan${vlan}_ingress
 		[ -z "${vingress}" ] && eval vingress=\$vlan${vlan}_ingress

Comment 1 rpisarev 2013-01-16 12:58:11 UTC

Hey.
Also saw that.

Сonfigs updated manually.

Comment 2 William Hubbs gentoo-dev

2013-02-17 21:42:08 UTC

 this is fixed in commit f36f8fb and will be in openrc-0.12.

report.
I don't understand the meaning of comment #1, but it looks like a
separate issue, so please open another bug.

Thanks,

William