$summary
Created attachment 350804 [details] ebuild for 3.0.4 hey, here is my first attempt to come up with a new 3.0.4 version, for review.. 1. add user patch support 2. add more dict IUSEs 3. fix g_thread_{init, creat} err due to >glib-2.31 4. USE=gucharmap requires --enable-deprecations problem: fail to compile festival and gpe, but I think these should report to upstream. I'm not sure whether to keep those IUSE and mask them in package.use.mask, or simply remove it. the former may allow us much more easily to accept patches from users.. Lan Yixun (dlan) (13): app-text/stardict: init, import original ebuild from official portage tree app-text/stardict: metadata, add myself as maintainer app-text/stardict: bumped version, only copy from 3.0.3, no changes app-text/stardict: modify according to new version (3.0.4) app-text/stardict: convert to src_prepare app-text/stardict: user patch support app-text/stardict: update configure options app-text/stardict: enable a few default dictionaries app-text/stardict: disable festival and gpe, it's broken, fail to compile app-text/stardict: add more dict related IUSEs.. app-text/stardict: glib patches, fix thread error app-text/stardict: fix deperacted macro problem app-text/stardict: manifest.xml generated I've put the full commit history in my overlay, branch "stardict" (use "layman -a dlan && git checkout origin/stardict")
Created attachment 350806 [details, diff] patch to fix g_thread_xx err, due to >glib-2.31
Created attachment 350808 [details, diff] ebuild diff, when compare with 3.0.3-r2
Created attachment 350810 [details] metadata.xml file, add IUSE and maintainer info
Created attachment 356884 [details] build.log Hello, this packages fails to build with dev-libs/glib-2.36.4 due to underlinking issue: libtool: link: i686-pc-linux-gnu-g++ -march=native -m32 -O2 -funswitch-loops -fpredictive-commoning -fgcse-after-reload -ftree-loop-im -fweb -frename-registers -fomit-frame-pointer -mfpmath=sse -pipe -frecord-gcc-switches -fvisibility-inlines-hidden -march=native -m32 -O2 -funswitch-loops -fpredictive-commoning -Wl,-O1 -Wl,--as-needed -pipe -o stardict stardict.o mainwin.o conf.o skin.o prefsdlg.o dictmanagedlg.o pluginmanagedlg.o floatwin.o readword.o selection.o splash.o gtktextviewpango.o pangoview.o articleview.o class_factory.o inifile.o x11_iskeyspressed.o docklet.o gtk_iskeyspressed.o progresswin.o tray.o dictmanage.o eggaccelerators.o globalhotkeys.o hotkeyeditor.o tomboykeybinder.o desktop.o log.o cmdlineopts.o -pthread lib/.libs/libstardict.a -lSM -lICE -lsigc-2.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lfreetype -lfontconfig -lgthread-2.0 -lglib-2.0 -lz -lX11 -pthread /usr/lib/gcc/i686-pc-linux-gnu/4.7.3/../../../../i686-pc-linux-gnu/bin/ld: lib/.libs/libstardict.a(pluginmanager.o): undefined reference to symbol 'g_module_symbol' This can be fixed by linking with libgmodule-2.0.so. It is used in dict/src/lib/pluginmanager.cpp but not linked to. Patch proposed below fixes this.
Created attachment 356886 [details, diff] stardict-3.0.4-gmodule-underlinking.patch Fix underlinking with gmodule-2.0.
Created attachment 356888 [details, diff] stardict-3.0.4.ebuild.patch Updated ebuild (just underlinking patch added).
Comment on attachment 350808 [details, diff] ebuild diff, when compare with 3.0.3-r2 Some major issues with this patch, can't go in as-is The whole purpose is to avoid deprecated dependencies, such as app-text/scrollkeeper which is a relic from old GNOME2 releases which got replaced long ago by app-text/rarian. No point in adding USE flags for options that don't bring in new dependencies, lets just let them be auto enabled on their own. No way libsigc++ is only a build-time DEPEND. How could it be when it's a shared library, and likely if it's used, stardict links against the library and then, the dependency would belong to RDEPEND and DEPEND, in this case I see COMMON_DEPEND is used in the ebuild. Also libsigc++ dependency needs a SLOT, either :1.2 or :2
Comment on attachment 356888 [details, diff] stardict-3.0.4.ebuild.patch seems like the problems from my last comment got forward ported here, obsoleting this attachement too
3.0.4 in portage w/ the underlinking issue fixed
