Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 451400 - app-dicts/wordnet with dev-lang/tcl-8.6.0 - replace interp -> result by call to Tcl_SetResult() routine
Summary: app-dicts/wordnet with dev-lang/tcl-8.6.0 - replace interp -> result by call ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Spell checking utilities and dictionaries -- related bugs (OBSOLETE)
URL:
Whiteboard:
Keywords: PATCH
: 451498 (view as bug list)
Depends on:
Blocks: tcltk-8.6
  Show dependency tree
 
Reported: 2013-01-11 14:07 UTC by milan hodoscek
Modified: 2013-03-03 07:54 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
replace interp -> result by call to Tcl_SetResult() routine (wordnet-3.0-tcl-8.6.patch,4.12 KB, patch)
2013-01-11 14:07 UTC, milan hodoscek 		Details | Diff
Modified patch for stubs.c (wordnet-3.0-stubs-c.patch,6.60 KB, text/plain)
2013-02-23 09:34 UTC, Bob Raitz 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description milan hodoscek 2013-01-11 14:07:22 UTC 
Created attachment 335186 [details, diff]
replace interp -> result by call to Tcl_SetResult() routine

wordnet does not compile with tcl-8.6.0 because of deprecated result field.
For details please see the attached patch
Comment 1 milan hodoscek 2013-01-11 23:51:42 UTC 
I also sent this patch upstream :-)
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2013-01-12 16:30:43 UTC 
*** Bug 451498 has been marked as a duplicate of this bug. ***
Comment 3 Yixun Lan archtester gentoo-dev 2013-02-01 06:55:10 UTC 
what's the response of upstream? did they accept?

actually I've tested this patch, it works. without this patch, compile fail too.
Comment 4 Bob Raitz 2013-02-23 09:34:20 UTC 
Created attachment 339780 [details]
Modified patch for stubs.c

I had to modify the patch slightly as it wouldn't epatch in the original condition as it exists here. That patch worked, and solved the issue. I offer that modified patch for those having issues with the first attachment.
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2013-03-01 13:46:51 UTC 
+  01 Mar 2013; Justin Lecher <jlec@gentoo.org> wordnet-3.0-r3.ebuild,
+  +files/wordnet-3.0-tcl8.6.patch, metadata.xml:
+  Fix compilation gainst tcl-8.6, #451400
+
Comment 6 Juergen Rose 2013-03-02 15:50:09 UTC 
Seems now to work for me.
Comment 7 milan hodoscek 2013-03-03 07:54:13 UTC 
(In reply to comment #5)
> +  01 Mar 2013; Justin Lecher <jlec@gentoo.org> wordnet-3.0-r3.ebuild,
> +  +files/wordnet-3.0-tcl8.6.patch, metadata.xml:
> +  Fix compilation gainst tcl-8.6, #451400
> +

It works directly from portage: without manual intervention - Thanks!!