Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 451172 - subversion eclass passes --ignore-externals to "svn info"
Summary: subversion eclass passes --ignore-externals to "svn info"
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Akinori Hattori
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-10 12:06 UTC by Burcin Erocal
Modified: 2013-01-11 15:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Burcin Erocal 2013-01-10 12:06:34 UTC
The comment for the variable ESVN_OPTIONS indicates that it is only used for checkout or update, but it is used for "svn info" as well.

If '--ignore-externals' is in ESVN_OPTIONS, merge fails with

>>> Unpacking source...
Subcommand 'info' doesn't accept option '--ignore-externals'
Type 'svn help info' for usage.
Subcommand 'info' doesn't accept option '--ignore-externals'
Type 'svn help info' for usage.
Subcommand 'info' doesn't accept option '--ignore-externals'
Type 'svn help info' for usage.
Subcommand 'info' doesn't accept option '--ignore-externals'
Type 'svn help info' for usage.
Subcommand 'info' doesn't accept option '--ignore-externals'
Type 'svn help info' for usage.
 * subversion switch start -->


Filtering this option from the arguments of 'svn info' fixes the problem:

diff --git a/eclass/subversion.eclass b/eclass/subversion.eclass
index b280f71..21cd813 100644
--- a/eclass/subversion.eclass
+++ b/eclass/subversion.eclass
@@ -468,7 +468,7 @@ subversion__svn_info() {
        local target="${1}"
        local key="${2}"

-       env LC_ALL=C svn info ${options} --username "${ESVN_USER}" --password "$
{ESVN_PASSWORD}" "${target}" \\
+       env LC_ALL=C svn info ${options/--ignore-externals/} --username "${ESVN_
USER}" --password "${ESVN_PASSWORD}" "${target}" \\
                | grep -i "^${key}" \\
                | cut -d" " -f2-
 }