Bug 450536 – net-ftp/vsftpd-3.0.2 prints warning: `vsftpd' uses 32-bit capabilities (legacy support in use) in kernel log

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Joakim Tjernlund 2013-01-06 14:26:56 UTC]

Created attachment 334658 [details, diff]
Patch to remove legacy capability warning.

vsftpd prints`vsftpd' uses 32-bit capabilities (legacy support in use) in kernel
log when built with USE -caps

I tracked the issues to sysdeputil.c where version is forced to:
 cap_head.version = _LINUX_CAPABILITY_VERSION;

After a little research I came up with the attached patch which seemingly
fixes the problem(by probing for preferred version)

[Comment 1 Markos Chandras (RETIRED) 2013-01-07 15:24:54 UTC]

not a Gentoo bug. You need to contact the upstream developer instead

[Comment 2 Joakim Tjernlund 2013-01-07 15:45:38 UTC]

(In reply to comment #1)
> not a Gentoo bug. You need to contact the upstream developer instead

Well, I tried that before with the kerberos patch I did long time ago. It is
still in the ebuild only, upstream seldom responds.

Anyhow I sent the patch upstream, perhaps it will work this time.

[Comment 3 Johan Bergström 2013-01-07 21:12:12 UTC]

I've also been annoyed by this for a while now. Regarding upstream, I've only occasionally actually gotten a email response. When having severe disconnection issues back in the 2.4 days, I actually got a better discussion at their IRC channel (#vsftpd) on freenode.

[Comment 4 Johan Bergström 2013-01-07 21:15:30 UTC]

(In reply to comment #3)
> I've also been annoyed by this for a while now. Regarding upstream, I've
> only occasionally actually gotten a email response. When having severe
> disconnection issues back in the 2.4 days, I actually got a better
> discussion at their IRC channel (#vsftpd) on freenode.

2.3, sorry - typo.

[Comment 5 Joakim Tjernlund 2013-01-07 21:20:37 UTC]

(In reply to comment #3)
> I've also been annoyed by this for a while now. Regarding upstream, I've
> only occasionally actually gotten a email response. When having severe
> disconnection issues back in the 2.4 days, I actually got a better
> discussion at their IRC channel (#vsftpd) on freenode.

Feel free to bump vsftpd on IRC. I don't do IRC these days, got too little time
to hang out there as well :(

[Comment 6 Joakim Tjernlund 2013-01-11 08:56:53 UTC]

(In reply to comment #2)
> (In reply to comment #1)
> > not a Gentoo bug. You need to contact the upstream developer instead
> 
> Well, I tried that before with the kerberos patch I did long time ago. It is
> still in the ebuild only, upstream seldom responds.
> 
> Anyhow I sent the patch upstream, perhaps it will work this time.

Been a few days now and no word from upstream. I guess I can wait a few more days
but I wanted to pose the idea that this is a gentoo problem.
It seems like gentoo has added the non caps feature as shown by:
 vsftpd-2.1.0-caps.patch
 vsftpd-2.2.0-dont-link-caps.patch

My patch simply builds upons the non caps feature.

[Comment 7 Markos Chandras (RETIRED) 2013-01-15 20:03:05 UTC]

(In reply to comment #6)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > not a Gentoo bug. You need to contact the upstream developer instead
> > 
> > Well, I tried that before with the kerberos patch I did long time ago. It is
> > still in the ebuild only, upstream seldom responds.
> > 
> > Anyhow I sent the patch upstream, perhaps it will work this time.
> 
> Been a few days now and no word from upstream. I guess I can wait a few more
> days
> but I wanted to pose the idea that this is a gentoo problem.
> It seems like gentoo has added the non caps feature as shown by:
>  vsftpd-2.1.0-caps.patch
>  vsftpd-2.2.0-dont-link-caps.patch
> 
> My patch simply builds upons the non caps feature.

the patch looks ok to me but I am not familiar with the code so it might have undesired effects that I can't predict. If the others maintainers are ok with this patch, I can commit it.

[Comment 8 Johan Bergström 2013-01-15 23:14:17 UTC]

I've tested the patch on amd64 and x86 but would prefer having some more arches test. In a sense, I guess that's what we have ~ for :)

[Comment 9 Joakim Tjernlund 2013-04-08 17:01:44 UTC]

Any chance this will make it into an unstable ebuild soon?

I alos noted this from man capset:
ERRORS
       EFAULT Bad  memory  address.  hdrp must not be NULL.  datap may be NULL
              only when the user is trying to determine the preferred capabil‐
              ity version format supported by the kernel.

Not sure why current vsftpd works with a NULL hdrp?

[Comment 10 Markos Chandras (RETIRED) 2013-04-09 08:41:47 UTC]

Is everyone ok with the attached patch? Anything else that needs to be done in the ebuild?

[Comment 11 Johan Bergström 2013-04-09 09:19:08 UTC]

(In reply to comment #10)
> Is everyone ok with the attached patch? Anything else that needs to be done
> in the ebuild?

I've tried the patch and can confirm that the warning goes away. My only request would be to test on more architectures since we're to carry a patch. As for the ebuild, I'll have a look tomorrow.

[Comment 12 Johan Bergström 2013-04-11 06:25:52 UTC]

I'm ok with the current ebuild. Feel free to go ahead (with adding attached patch with epatch) if you have no other objections.

[Comment 13 Markos Chandras (RETIRED) 2013-04-20 16:49:12 UTC]

+*vsftpd-3.0.2-r1 (20 Apr 2013)
+
+  20 Apr 2013; Markos Chandras <[e-mail]> +vsftpd-3.0.2-r1.ebuild,
+  +files/vsftpd-3.0.2-remove-legacy-cap.patch, +files/vsftpd.service,
+  +files/vsftpd-checkconfig.sh, files/vsftpd.init:
+  Add systemd unit file. Bug #466340 thanks to Fabio Erculiani
+  <[e-mail]>. Add patch to remove legacy capabilities by
+  Joakim Tjernlund <[e-mail]>. Bug #450536
+