Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 450494 - media-libs/oyranos-0.9.3: version bump request
Summary: media-libs/oyranos-0.9.3: version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Weber (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-06 05:21 UTC by Chris Reffett (RETIRED)
Modified: 2013-04-25 21:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
oyranos-0.9.3.ebuild (oyranos-0.9.3.ebuild,1.97 KB, text/plain)
2013-01-06 16:27 UTC, Chris Reffett (RETIRED)
Details
oyranos-0.9.3-buildsystem.patch (oyranos-0.9.3-buildsystem.patch,3.31 KB, patch)
2013-01-06 16:28 UTC, Chris Reffett (RETIRED)
Details | Diff
oyranos-0.9.4.ebuild.diff (oyranos-0.9.4.ebuild.diff,2.28 KB, patch)
2013-02-03 19:20 UTC, Andreas Sturmlechner
Details | Diff
oyranos-0.9.3-fix-flmm_tabs-include.patch (oyranos-0.9.3-fix-flmm_tabs-include.patch,288 bytes, patch)
2013-02-03 19:24 UTC, Andreas Sturmlechner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Reffett (RETIRED) gentoo-dev Security 2013-01-06 05:21:01 UTC
Oyranos 0.9.3 is out, and this is a dependency of the latest version of kolor-manager. The changelog for 0.9.2 and 0.9.3 is rather long, and among other things it looks like they did a redo of the build system. I'll look this over tomorrow and see if I can come up with a working ebuild to review.
Comment 1 Michael Weber (RETIRED) gentoo-dev 2013-01-06 10:11:26 UTC
(In reply to comment #0)
> ... it looks like they did a redo of the build system. 
Just shoot upstream in general for such behaviour.

> I'll look this over tomorrow and see if I can come up with a working ebuild to review.
I'd appreciate any help!
Comment 2 Chris Reffett (RETIRED) gentoo-dev Security 2013-01-06 16:27:04 UTC
Created attachment 334670 [details]
oyranos-0.9.3.ebuild

Here's a first crack at an ebuild. Not working quite yet, it fails with not being able to find FL/(someheader).H. The problem is twofold here: first, the .H instead of .h isn't helping, and second, the include path is missing /usr/include/fltk-1. I assume it's possible to just sed/patch all of these instances to be #include <fltk-1/FL/header.h>, but simpler would probably be to correctly detect the include path instead.
Comment 3 Chris Reffett (RETIRED) gentoo-dev Security 2013-01-06 16:28:36 UTC
Created attachment 334672 [details, diff]
oyranos-0.9.3-buildsystem.patch

Re-rolled version of the buildsystem patch, several things disappeared between the versions but this one at least applies. Adds functionality to make building the tests optional as well.
Comment 4 Andreas Sturmlechner gentoo-dev 2013-02-03 13:45:24 UTC
oyranos-0.9.4 released - builds up to the same point of error as 0.9.3
Comment 5 Andreas Sturmlechner gentoo-dev 2013-02-03 14:23:59 UTC
I believe there is also a problem with some fltk include files themselves. I've begun sedding through the troubled oyranos sources files inside src/examples/image_display - and then it comes to this:


In file included from /var/tmp/portage/media-libs/oyranos-0.9.4/work/oyranos-0.9.4/src/examples/image_display/Oy_Fl_Image_Widget.h:7:0,
                 from /var/tmp/portage/media-libs/oyranos-0.9.4/work/oyranos-0.9.4/src/examples/image_display/oyranos_display_helper_classes_fltk.cpp:28,
                 from /var/tmp/portage/media-libs/oyranos-0.9.4/work/oyranos-0.9.4/src/examples/image_display/image_display.cpp:35:
/usr/include/fltk-1/FL/fl_draw.H:36:40: fatal error: FL/x.H: No such file or directory


In file included from /usr/include/fltk-1/FL/fl_draw.H:39:0,
                 from /var/tmp/portage/media-libs/oyranos-0.9.4/work/oyranos-0.9.4/src/examples/image_display/Oy_Fl_Image_Widget.h:7,
                 from /var/tmp/portage/media-libs/oyranos-0.9.4/work/oyranos-0.9.4/src/examples/image_display/oyranos_display_helper_classes_fltk.cpp:28,
                 from /var/tmp/portage/media-libs/oyranos-0.9.4/work/oyranos-0.9.4/src/examples/image_display/image_display.cpp:35:
/usr/include/fltk-1/FL/Fl_Device.H:36:18: fatal error: FL/x.H: No such file or directory


So there are headers in the fltk package that themselves need to be moved out of FL into fltk-1 or have their include paths fixed.
Comment 6 Andreas Sturmlechner gentoo-dev 2013-02-03 15:32:07 UTC
src/examples/oyranos_config_fltk.h

wants to include

FL/Flmm_Tabs.H

which is not part of at least my x11-libs/fltk-1.3.0-r1 build.
Comment 7 Andreas Sturmlechner gentoo-dev 2013-02-03 19:20:39 UTC
Created attachment 337844 [details, diff]
oyranos-0.9.4.ebuild.diff

diff to 0.9.4 against in-tree 0.9.1.ebuild (butchering with sed through several source files)

It builds with USE="-X" only after manually editing the following ftlk headers:
/usr/include/fltk-1/FL/fl_draw.H
/usr/include/fltk-1/FL/Fl_Device.H
/usr/include/fltk-1/FL/Fl_File_Chooser.H
/usr/include/fltk-1/FL/Fl_Browser_.H
/usr/include/fltk-1/FL/Fl_File_Input.H
/usr/include/fltk-1/FL/Fl_Pack.H


It also correctly handles docs, but prints the following message:

scanelf: rpath_security_checks(): Security problem NULL DT_RPATH in /var/tmp/portage/media-libs/oyranos-0.9.4/image/usr/bin/oyranos-xforms-modules
scanelf: rpath_security_checks(): Security problem NULL DT_RUNPATH in /var/tmp/portage/media-libs/oyranos-0.9.4/image/usr/bin/oyranos-xforms-modules
Auto fixing rpaths for /var/tmp/portage/media-libs/oyranos-0.9.4/image/usr/bin/oyranos-xforms-modules

 * QA Notice: The following files contain insecure RUNPATHs
 *  Please file a bug about this at http://bugs.gentoo.org/
 *  with the maintaining herd of the package.
 *   /var/tmp/portage/media-libs/oyranos-0.9.4/image/usr/bin/oyranos-xforms-modules
 *
Comment 8 Andreas Sturmlechner gentoo-dev 2013-02-03 19:24:54 UTC
Created attachment 337846 [details, diff]
oyranos-0.9.3-fix-flmm_tabs-include.patch

just a small fix to succeed with compilation
Comment 9 Michael Weber (RETIRED) gentoo-dev 2013-03-23 09:24:32 UTC
It dies with 

[ 94%] Building CXX object src/examples/CMakeFiles/image-display.dir/image_display/image_display.cpp.o
In file included from /tmp/portage/media-libs/oyranos-0.9.4/work/oyranos-0.9.4/src/examples/image_display/Oy_Fl_Image_Widget.h:7:0,
                 from /tmp/portage/media-libs/oyranos-0.9.4/work/oyranos-0.9.4/src/examples/image_display/oyranos_display_helper_classes_fltk.cpp:28,
                 from /tmp/portage/media-libs/oyranos-0.9.4/work/oyranos-0.9.4/src/examples/image_display/image_display.cpp:35:
/usr/include/fltk-1/FL/fl_draw.H:27:41: fatal error: FL/x.H: No such file or directory  
compilation terminated.
make[2]: *** [src/examples/CMakeFiles/image-display.dir/image_display/image_display.cpp.o] Error 1
make[1]: *** [src/examples/CMakeFiles/image-display.dir/all] Error 2
make: *** [all] Error 2

looks like it misses -I/usr/include/fltk-1, as mentioned by chris.
I try to turn on verbose rules and so on ...
Comment 10 Michael Weber (RETIRED) gentoo-dev 2013-03-23 18:17:02 UTC
+  23 Mar 2013; Michael Weber <xmw@gentoo.org> package.use.mask:
+  mask =media-libs/oyranos-0.9.4 fltk for now
+

+*oyranos-0.9.4 (23 Mar 2013)
+
+  23 Mar 2013; Michael Weber <xmw@gentoo.org> -oyranos-0.9.0.ebuild,
+  -oyranos-0.9.1.ebuild, +oyranos-0.9.4.ebuild,
+  +files/oyranos-0.9.4-buildsystem.patch:
+  Version bump (bug 450494, thanks Chris Reffett and Andreas Sturmlechner for
+  their contribution), ebuild rewritten from scratch (cudos upstream for
+  nothing), drop old.
+