Created attachment 333902 [details, diff] patch to build luatex against poppler 0.22 Just like it was with poppler 0.20, this release breaks it again. Unlike bug 416545, there's a pretty good chance the attached patch isn't quite correct, as a new argument needs to be added and I can't tell how exactly is luatex calling these functions (as they're all static), so I can't test these changes and - quite obviously - as this time an argument is added, instead of removed, anything that used to call this constructor *will* be broken.
As a side note, luatex 0.72 is out; the announcement claims support for poppler 0.21.
Given is says '0.21' makes it sound a bit fishy - while on odd number, some of the changes, including API tends to not make it out of the repo. But good to know, even if the short gap between 0.72 and 0.74 makes me a bit suspicious given their usual release timing **cough**brown bag**cough**.
(In reply to comment #0) > Unlike bug 416545, there's a pretty good chance the attached patch isn't > quite correct, as a new argument needs to be added and I can't tell how > exactly is luatex calling these functions (as they're all static), so I > can't test these changes and - quite obviously - as this time an argument is > added, instead of removed, anything that used to call this constructor > *will* be broken. Yep. (Actually the function is called nowhere in the luatex code.) I conclude that we cannot do anything about it inside luatex, since the data has to come from somewhere and be placed onto the stack as 4th argument. E.g. in a lua script? Since this is the last package blocking poppler upgrade and since poppler has a couple of sec bugs, I'm placing an explicit dep on <poppler-0.20 here for now.
This should be fixed in luatex-0.70.1-r2. (Upstream went a different way and basically removed that part of the exported lua interface completely.)
(In reply to comment #4) > This should be fixed in luatex-0.70.1-r2. > > (Upstream went a different way and basically removed that part of the > exported lua interface completely.) Hey uhm, just saying, but, could you please commit a patch that actually applies? * Applying poppler022.patch ... * Failed Patch: poppler022.patch ! * ( /usr/portage/dev-tex/luatex/files/poppler022.patch ) And the excerpt from /var/tmp/portage/dev-tex/luatex-0.70.1-r2/temp/poppler022.patch.out: PATCH COMMAND: patch -p2 -g0 -E --no-backup-if-mismatch < '/usr/portage/dev-tex/luatex/files/poppler022.patch' ============================ patching file texk/web2c/luatexdir/lua/lepdflib.cc Hunk #2 FAILED at 19. 1 out of 25 hunks FAILED -- saving rejects to file texk/web2c/luatexdir/lua/lepdflib.cc.rej
Created attachment 341604 [details, diff] poppler022.patch Corrected patch: second chunk is replaced by a proper data.
This updated patch fixes the problem for me. Thanks for the quick work.
