Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 448690 - test-flag-PROG() in flag-o-matic.eclass is broken ( was: sys-apps/v86d/v86d-0.1.10 fails to compile)
Summary: test-flag-PROG() in flag-o-matic.eclass is broken ( was: sys-apps/v86d/v86d-0...
Status: RESOLVED DUPLICATE of bug 445244
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Hardened (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-26 18:26 UTC by Maxim Kammerer
Modified: 2013-01-03 17:15 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Kammerer 2012-12-26 18:26:34 UTC
klcc -c -Os -march=pentium3 -mtune=core2 -mfpmath=sse -fomit-frame-pointer -pipe -fno-stack-protector -fno-stack-protector-all -I/usr/src/linux/include -Ilibs/x86emu -I. -I../../include -I../../include/x86emu -o decode.o decode.c
cc1: error: unrecognized command line option "-fno-stack-protector-all"

In the ebuild:
    filter-flags -fstack-protector -fstack-protector-all

Last successful build of v86d on my machine was at Sep 21 2012, and it seems that what broke the build (adding -fno-... for non-present flags due to filter-flags) should be in flag-o-matic.eclass commits since then, but I can't find something that seems relevant in CVS.
Comment 1 Maxim Kammerer 2012-12-26 18:29:57 UTC
Forgot to mention, the problem is only present on hardened. So it's probably something to do with _filter-hardened() in flag-o-matic.eclass.
Comment 2 Maxim Kammerer 2012-12-26 18:46:16 UTC
This is the offending commit:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/flag-o-matic.eclass?r1=1.185&r2=1.186

Reversing it fixes the issue: -fno-stack-protector-all is not added to klcc (-fno-stack-protector is still added, but klcc from stable dev-libs/klibc-1.5.20 supports it).
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2012-12-26 18:56:34 UTC
Short summary:
Mike did some unreviewed changes to the eclass

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/flag-o-matic.eclass?r1=1.181&r2=1.182

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/flag-o-matic.eclass?r1=1.181&r2=1.182

which broke compatibility for <gcc-4.7 and intel compilers
see: bug 443778 and bug 445244

I tried to commit a fix but this let to this bug here. The whole thing needs to be fixed or reverted to original state.

@qa
Could you please supervise the changes made?

@Mike
Please fix this whole thing.
I am sorry that my commit breaks something additionally, but broken things for stable packages.
Comment 4 SpanKY gentoo-dev 2012-12-26 19:32:12 UTC

*** This bug has been marked as a duplicate of bug 445244 ***
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2012-12-26 21:28:56 UTC
this bug is not fixed. The eclass function does not work.
Comment 6 SpanKY gentoo-dev 2012-12-28 19:26:19 UTC
no one said this was fixed.  it's a dupe of an existing bug.

*** This bug has been marked as a duplicate of bug 445244 ***