446556 – sys-app/openrc-0.11.8 - Apply patch for quoting issues in localmount.

Bug 446556 - sys-app/openrc-0.11.8 - Apply patch for quoting issues in localmount.

Summary: sys-app/openrc-0.11.8 - Apply patch for quoting issues in localmount.

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Core system (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	OpenRC Team

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:	439098
	Show dependency tree

Reported:	2012-12-09 01:29 UTC by Steve L
Modified:	2012-12-17 02:08 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
localmount.patch (file_446556.txt,953 bytes, patch) 2012-12-09 01:31 UTC, Steve L	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve L 2012-12-09 01:29:11 UTC

There are a couple of minor quoting issues with the new localmount. Additionally, there is a use of echo which is unsafe, especially if portability is a concern.

Attaching a patch in next comment.

Reproducible: Always

Comment 1 Steve L 2012-12-09 01:31:27 UTC

Created attachment 331846 [details, diff]
localmount.patch

The echo line is already being edited in this patch to fix quoting, so I don't see the point in a separate patch. Pretty minor in any case.

Comment 2 William Hubbs gentoo-dev

2012-12-17 02:07:59 UTC

This has been applied in commit 8d61d03. Thanks for the report.