Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 445662 - x11-apps/xdm: considering disabling xdm auth by default
Summary: x11-apps/xdm: considering disabling xdm auth by default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-02 17:18 UTC by Michał Górny
Modified: 2019-03-03 02:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-12-02 17:18:47 UTC
As of the last xdm users in Gentoo, I think it may actually be a good idea to disable the xdm auth support. It's not supported by other DMs, and causes issues with libreoffice and some SDL games.

Shortly saying, the issue happens when an app using X11 uses exec() to spawn another app using X11.

$ lowriter 
XDM authorization key matches an existing client!/usr/lib64/libreoffice/program/soffice.bin X11 error: Can't open display: 
   Set DISPLAY environment variable, use -display option
   or check permissions of your X-Server
   (See "man X" resp. "man xhost" for details)

I'd say the simplest solution would be to disable xdm-auth and let xdm use the same ol' auth as other DMs do.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-12-03 20:19:06 UTC
I've checked it and it's enough to add to xdm-config:

  DisplayManager*authName:    MIT-MAGIC-COOKIE-1

(therefore disabling XDM-AUTHORIZATION-1)

If noone objects, I'll commit it in a few days.
Comment 2 Rémi Cardona (RETIRED) gentoo-dev 2012-12-03 23:36:08 UTC
@Michał, please wait a bit before acting on this.

@x11, I must say I have very little knowledge about this and have no objections either way. What say you?

Thanks
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-12-08 08:36:57 UTC
Committed p.masked as discussed.
Comment 4 Chí-Thanh Christopher Nguyễn gentoo-dev 2013-07-02 09:58:35 UTC
xdm-1.11.1-r3 is now unmasked in tree and makes xdm-auth optional.
Comment 5 Larry the Git Cow gentoo-dev 2019-03-03 02:09:53 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9eab4843656a9d806f902602ccb19584f8863792

commit 9eab4843656a9d806f902602ccb19584f8863792
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2019-03-03 00:27:58 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2019-03-03 02:09:37 +0000

    x11-apps/xdm: Version bump to 1.1.2
    
    Various changes, addressing multiple bugs (in some cases partially):
            - Depend on x11-apps/xsm (bug 329833)
            - Drop IUSE=xdm-auth (bug 445662)
            - Add IUSE=xinerama (bug 384371)
            - Add IUSE=truetype (bug 608840)
            - Add IUSE=xpm
            - Add IUSE=systemd
            - Port to EAPI=7 and xorg-3.eclass
    
    Bug: https://bugs.gentoo.org/329833
    Bug: https://bugs.gentoo.org/445662
    Closes: https://bugs.gentoo.org/384371
    Closes: https://bugs.gentoo.org/608840
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 x11-apps/xdm/Manifest                              |   1 +
 x11-apps/xdm/files/xdm-1.1.12-consolekit.patch     | 269 +++++++++++++++++++++
 .../files/xdm-1.1.12-make-xinerama-optional.patch  |  34 +++
 x11-apps/xdm/xdm-1.1.12.ebuild                     |  84 +++++++
 4 files changed, 388 insertions(+)