Bug 444692 – net-misc/aiccu: add systemd support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Łukasz Stelmach 2012-11-25 13:59:05 UTC]

The patches introduce systemd's sd_notify(3) to tell systemd that the service is ready. They should be applied after all other patches for both r1 and r2.

The service file (doc/aiccu.service) enable systemd to control aiccu. The aiccu.service is defined to start after the network.target. It probably should not be so because aiccu provides network connectivity, but there is no network-ipv4.target which could provide IPv4 required for aiccu. Any comments on this are welcome.



Reproducible: Always

[Comment 1 Łukasz Stelmach 2012-11-25 14:00:21 UTC]

Created attachment 330542 [details, diff]
Systemd support for net-misc/aiccu-2007.01.15-r1

[Comment 2 Łukasz Stelmach 2012-11-25 14:00:44 UTC]

Created attachment 330544 [details]
Systemd support for net-misc/aiccu-2007.01.15-r2

[Comment 3 Łukasz Stelmach 2012-11-25 14:01:56 UTC]

Created attachment 330546 [details, diff]
Systemd support for net-misc/aiccu-2007.01.15-r2

[Comment 4 Jeroen Roovers (RETIRED) 2012-11-26 13:36:55 UTC]

CC: 	[e-mail] did not match anything

Please fix metadata.xml

[Comment 5 Michael Weber (RETIRED) 2012-12-01 20:54:59 UTC]

(In reply to comment #4)
> CC: 	[e-mail] did not match anything
> 
> Please fix metadata.xml

+  01 Dec 2012; Michael Weber <[e-mail]> metadata.xml:
+  Removing Maciej from metadata.xml
+

[Comment 6 Łukasz Stelmach 2013-03-16 11:05:33 UTC]

ping?

[Comment 7 Michael Weber (RETIRED) 2013-05-24 06:44:30 UTC]

This patch needs systemd/sd-daemon.h to compile.
I get the general idea and add #define HAVE_SYSTEMD

[Comment 8 Michael Weber (RETIRED) 2013-05-24 07:53:09 UTC]

Since -r2 got stabled, I dropped -r1.
I've added -r3 with a modified version of the -r2 patch, see [1] for details.
I could not test USE=systemd, because I have no system with the need header/libs.

Please test and report errors or close RESO/FIXED. Thanks

+*aiccu-2007.01.15-r3 (24 May 2013)
+
+  24 May 2013; Michael Weber <[e-mail]> +aiccu-2007.01.15-r3.ebuild,
+  +files/aiccu-2007.01.15-systemd.patch, -aiccu-2007.01.15-r1.ebuild:
+  Add systemd support (thanks Łukasz Stelmach, bug 444692)
+

[1] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-misc/aiccu/files/aiccu-2007.01.15-systemd.patch?view=log

[Comment 9 Łukasz Stelmach 2013-05-26 21:20:17 UTC]

Almost works. Please change:

+ifeq (1,HAVE_SYSTEMD)

to

+ifeq (1,$(HAVE_SYSTEMD))

in the Makefile section of the patch.

[Comment 10 Michael Weber (RETIRED) 2013-05-27 05:24:35 UTC]

(In reply to Łukasz Stelmach from comment #9)
> Almost works. Please change:
> +ifeq (1,$(HAVE_SYSTEMD))

done, revbump to force re-evaluation.

+*aiccu-2007.01.15-r4 (27 May 2013)
+
+  27 May 2013; Michael Weber <[e-mail]> +aiccu-2007.01.15-r4.ebuild,
+  -aiccu-2007.01.15-r3.ebuild, files/aiccu-2007.01.15-systemd.patch:
+  Fix test in Makefile patch, thanks Łukasz Stelmach for testing
+