Bug 444046 – media-sound/mangler does not respect CC

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2012-11-20 13:51:30 UTC]

It calls gcc directly in one line:

gdk-pixbuf-csource --raw --build-list $list > mangler-icons.h
make[2]: Leaving directory `/var/tmp/portage/media-sound/mangler-1.2.4/work/mangler-1.2.4/icons'
Making all in sounds
make[2]: Entering directory `/var/tmp/portage/media-sound/mangler-1.2.4/work/mangler-1.2.4/sounds'
gcc -Wall -o bin2h bin2h.c
./bin2h channelenter.raw channelenter.h sound_channelenter
./bin2h channelleave.raw channelleave.h sound_channelleave
./bin2h login.raw login.h sound_login
./bin2h logout.raw logout.h sound_logout
./bin2h: conversion done

[Comment 1 Matthew Thode ( prometheanfire ) 2012-11-20 20:17:12 UTC]

this is patched upstream but not released, I could release an instance based off a git tag, (off of a fork). but that seems like overkill, think it's best to wait for 1.2.5 (if it ever comes out).

[Comment 2 Julian Ospald 2012-11-21 10:59:33 UTC]

this is important QA and should always be fixed for stable packages imo

--- sounds/Makefile
+++ sounds/Makefile
@@ -2,7 +2,7 @@
 all: mangler-sounds.h
 
 bin2h: bin2h.c
-	gcc -Wall -o bin2h bin2h.c
+	$(CC) $(CFLAGS) -Wall -o bin2h bin2h.c
 
 mangler-sounds.h: bin2h channelenter.h channelleave.h login.h logout.h talkend.h talkstart.h
 	cat channelenter.h channelleave.h login.h logout.h talkend.h talkstart.h > mangler-sounds.h


that along with the usual tc-getCC in emake-line should do the trick until the next release

[Comment 3 Agostino Sarubbo 2012-11-21 11:01:40 UTC]

no problem, wait is fine

[Comment 4 Matthew Thode ( prometheanfire ) 2012-11-22 05:39:12 UTC]

upstream has agreed to create a release to fix this gentoo bug on receiving of beer to be provided by me on Nov 30, 2012

[Comment 5 Matthew Thode ( prometheanfire ) 2013-01-16 03:46:11 UTC]

fixed in 1.2.5

[Comment 6 Agostino Sarubbo 2013-03-10 13:24:10 UTC]

this is not fixed in 1.2.5

cc -march=native -O2 -g0 -pipe -pthread   -c -o bin2h.o bin2h.c
cc -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu  bin2h.o   -o bin2h

[Comment 7 Michael Mair-Keimberger (iamnr3) 2013-06-16 10:24:22 UTC]

Created attachment 351102 [details, diff]
mangler-1.2.5.patch

Patch against latest ebuild: (please review)
tc-export CC in src_configure() (and inherit toochain-func) is enough to fix this issue.

[Comment 8 Matthew Thode ( prometheanfire ) 2013-06-18 12:55:08 UTC]

fixed in media-sound/mangler-1.2.5-r1