Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 441970 - net-misc/dhcp: Fedora patches should be considered for inclusion
Summary: net-misc/dhcp: Fedora patches should be considered for inclusion
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: http://pkgs.fedoraproject.org/cgit/dh...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 00:52 UTC by Pavel Šimerda (pavlix)
Modified: 2016-12-17 15:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Šimerda (pavlix) 2012-11-06 00:52:55 UTC
In Fedora, there are lots of important patches to the ISC DHCP suite:

http://pkgs.fedoraproject.org/cgit/dhcp.git/tree/dhcp.spec

The patches are commented, so it should not be too hard to distinguish
patches we want from patches we don't want. The upstream project is
pretty much dead and nobody knows if it ever starts again to accept
patches or not.

A notable patch dhcp-4.2.4-P1-interval.patch fixes a problem that caused
many people not to be able to connect to the wireless network at GUADEC.
But there may be other important fixes.

Of course, if anyone has an idea how to upstream the patches or keep a
reasonable cross-distro patchset, it will be most welcome.
Comment 1 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2012-11-06 03:28:56 UTC
Mailing lists, requests and reporting information can be found at

    http://www.isc.org/software/dhcp/news
Comment 2 Pavel Šimerda (pavlix) 2012-11-06 11:26:26 UTC
(In reply to comment #1)
> Mailing lists, requests and reporting information can be found at
> 
>     http://www.isc.org/software/dhcp/news

The link in this bug reports points to the Fedora spec file. The %patch
commands in the spec file are commented. All patches that were already
submitted to ISC are marked as such.

I kindly ask you to read the description in this bug report once again
and more carefully.
Comment 3 Pavel Šimerda (pavlix) 2012-11-14 18:55:55 UTC
For convenience, the patch comments taken out form the specfiles:

# Fire away bundled BIND source.
%patch28 -p1 -b .remove-bind %{?_rawbuild}

# Fire away libdst
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #30692])
%patch29 -p1 -b .remove-dst %{?_rawbuild}

# Replace the standard ISC warning message about requesting help with an
# explanation that this is a patched build of ISC DHCP and bugs should be
# reported through bugzilla.redhat.com
%patch0 -p1 -b .errwarn

# Add more dhclient options (-I, -B, -H, -F, -timeout, -V, and -R)
%patch1 -p1 -b .options

# Handle releasing interfaces requested by /sbin/ifup
# pid file is assumed to be /var/run/dhclient-$interface.pid
%patch2 -p1 -b .ifup

# If we receive a DHCP offer in dhclient and it's DECLINEd in dhclient-script,
# backoff for an amount of time before trying again
%patch3 -p1 -b .backoff

# Support unicast BOOTP for IBM pSeries systems (and maybe others)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #19146])
%patch4 -p1 -b .unicast

# Add NIS domain, NIS servers, NTP servers, interface-mtu and domain-search
# to the list of default requested DHCP options
%patch7 -p1 -b .requested

# Handle Xen partial UDP checksums
%patch8 -p1 -b .xen

# Various man-page-only fixes
%patch10 -p1 -b .man

# Change paths to conform to our standards
%patch11 -p1 -b .paths

# Make sure all open file descriptors are closed-on-exec for SELinux (#446632)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #19148])
%patch12 -p1 -b .cloexec

# Fix 'garbage in format string' error (#450042)
%patch14 -p1 -b .garbage

# If the ipv6 kernel module is missing, do not segfault
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #19367])
%patch15 -p1 -b .noipv6

# Handle cases in add_timeout() where the function is called with a NULL
# value for the 'when' parameter
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #19867])
%patch17 -p1 -b .dracut

# Ensure 64-bit platforms parse lease file dates & times correctly (#448615, #628258)
# (Partly submitted to dhcp-bugs@isc.org - [ISC-Bugs #22033])
%patch18 -p1 -b .64-bit_lease_parse

# Drop unnecessary capabilities in
# dhclient (#517649, #546765), dhcpd/dhcrelay (#699713)
%patch19 -p1 -b .capability

# dhclient logs its pid to make troubleshooting NM managed systems
# with multiple dhclients running easier (#546792)
%patch20 -p1 -b .logpid

# Discard unicast Request/Renew/Release/Decline message
# (unless we set unicast option) and respond with Reply
# with UseMulticast Status Code option (#573090)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #21235])
%patch21 -p1 -b .UseMulticast

# If any of the bound addresses are found to be in use on the link,
# the dhcpv6 client sends a Decline message to the server
# as described in section 18.1.7 of RFC-3315 (#559147)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #21237])
%patch22 -p1 -b .sendDecline

# In client initiated message exchanges stop retransmission
# upon reaching the MRD rather than at some point after it (#559153)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #21238])
%patch23 -p1 -b .retransmission

# RFC 3442 - Classless Static Route Option for DHCPv4 (#516325)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #24572])
%patch25 -p1 -b .rfc3442

# check whether there is any unexpired address in previous lease
# prior to confirming (INIT-REBOOT) the lease (#585418)
# (Submitted to dhcp-suggest@isc.org - [ISC-Bugs #22675])
%patch27 -p1 -b .honor-expired

#Build dhcp's libraries as shared libs instead of static libs.
%patch30 -p1 -b .sharedlib

# DHCPv6 over PPP support (#626514)
%patch31 -p1 -b .PPP

# dhcpd: BEFORE changing of the effective user/group ID:
#  - write PID file (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #25806])
#  - chown leases file (#866714)
%patch32 -p1 -b .paranoia

# IPoIB support (#660681)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #24249])
%patch33 -p1 -b .lpf-ib
%patch34 -p1 -b .improved-xid
%patch35 -p1 -b .gpxe-cid

# http://sourceware.org/systemtap/wiki/SystemTap
%patch36 -p1 -b .systemtap

# Send DHCPDECLINE and exit(2) when duplicate address was detected and
# dhclient had been started with '-1' (#756759).
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #26735])
%patch37 -p1 -b .decline-onetry

# Don't send log messages to the standard error descriptor by default (#790387)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #28049])
%patch38 -p1 -b .log_perror

# Use getifaddrs() to scan for interfaces on Linux (#449946)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #28761])
%patch39 -p1 -b .getifaddrs

# Don't use fallback_interface when releasing lease (#800561)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #30544])
%patch40 -p1 -b .send_release

# RFC5970 - DHCPv6 Options for Network Boot (#798735)
%patch41 -p1 -b .rfc5970

# Dhcpd does not correctly follow DhcpFailOverPeerDN (#838400)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #30402])
%patch42 -p1 -b .failOverPeer

# Dhclient does not correctly parse zero-length options in dhclient6.leases (#633318)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #27314])
%patch43 -p1 -b .dhclient6-leases_semicolon

# isc_time_nowplusinterval() is not safe with 64-bit time_t (#662254, #789601)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #28038])
%patch44 -p1 -b .interval

# do-forward-updates statement wasn't recognized (#863646)
# (Submitted to dhcp-bugs@isc.org - [ISC-Bugs #31328])
%patch45 -p1 -b .forward-updates.patch
Comment 4 Warren Chartier 2016-12-17 15:52:30 UTC
Please add the patches for infiniband support.

Internet Systems Consortium DHCP Server 4.3.4 Gentoo-r0
Copyright 2004-2016 Internet Systems Consortium.
All rights reserved.
For info, please visit https://www.isc.org/software/dhcp/
Config file: /etc/dhcp/dhcpd.conf
Database file: /var/lib/dhcp/dhcpd.leases
PID file: /var/run/dhcp/dhcpd.pid
Wrote 0 leases to leases file.
Unsupported device type 32 for "ib0"
If you think you have received this message due to a bug rather
than a configuration issue please read the section on submitting
bugs on either our web page at www.isc.org or in the README file
before submitting a bug.  These pages explain the proper
process and the information we find helpful for debugging..
exiting.