Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 441754 - net-misc/NetworkManager-0.9.6.4 - Upstream the 0.9.2.0-init-provide-net-r1.patch or package the whole initscript.
Summary: net-misc/NetworkManager-0.9.6.4 - Upstream the 0.9.2.0-init-provide-net-r1.pa...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nirbheek Chauhan (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-04 14:55 UTC by Pavel Šimerda
Modified: 2013-11-24 20:42 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Šimerda 2012-11-04 14:55:03 UTC
NetworkManager Gentoo initscripts are currently maintained in the NetworkManager
project and patched again in Gentoo. This does not make sense.

In NetworkManager master, we already removed --with-distro option and initscripts
are not installed automatically:

commit 3ee36a6f7458d44f1197a9d00b51c580033f29a7
Author: Pavel Šimerda <psimerda@redhat.com>
Date:   Thu Aug 2 16:52:33 2012 +0200

    distro: don't install initscripts
    
    It doesn't make much sense to install initscripts in current distributions. Most
    of them either don't use initscripts at all, locally patch the initscripts or
    supply their own. This allows us to eventually drop the --with-distro configure
    option.
    
    Many current distributions support multiple init systems and it doesn't make
    sense for upstream to make the choice for them. Distributors can still make
    their scripts copy one of the initscripts from the source tree if they wish so.

commit 012c5f4b271b935852267ed865933ea3bb6983ba
Author: Pavel Šimerda <psimerda@redhat.com>
Date:   Wed Aug 1 20:01:33 2012 +0200

    distro: replace --with-distro with feature-based options (bgo #663602)
    
    Distribution-specific builds are now handled by feature and not by
    distro. This allows you to fine-tune the options to your liking and
    also allowed us to reduce the number of specific values.
    
    The default values of these options are still derived from *-version
    and *-release files in /etc.
    
    The following five distribution-specific features are now available
    (and default on distributions in parenthesis):
    
      --enable-ifcfg-rh (Fedora, RHEL and Mandriva)
      --enable-ifcfg-suse (SUSE)
      --enable-ifupdown (Debian and Ubuntu)
      --enable-ifnet (Gentoo)
      --with-netconfig (SUSE)
    
    Since --with-distro is now removed, there is nothing to prevent generic
    builds. If you build on an unknown distribution, all of the features
    above will be disabled by default.

In my opinion, the best option is to maintain the whole initscript at Gentoo and remove it from NetworkManager Git.
Comment 1 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2012-11-04 20:59:28 UTC
Maintainers of net-misc/networkmanager have been added CC.
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-11-05 03:32:56 UTC
The init script installed by current Gentoo networkmanager ebuilds is not upstreamable because it makes sense only with our /etc/NetworkManager/dispatcher.d/10-openrc-status script, which in turn depends on the networkmanager-0.9.2.0-pre-sleep patch.

In other words, we are waiting for https://bugzilla.gnome.org/show_bug.cgi?id=387832 to finally be fixed :)

If you want to remove the old Gentoo init script from networkmanager upstream, we are also fine with that; it's not much of an inconvenience for us, and networkmanager is your code, so the decision is up to you.
Comment 3 Pavel Šimerda 2012-11-05 09:27:22 UTC
> The init script installed by current Gentoo networkmanager ebuilds is not
> upstreamable because it makes sense only with our
> /etc/NetworkManager/dispatcher.d/10-openrc-status script, which in turn
> depends on the networkmanager-0.9.2.0-pre-sleep patch.

Erm... nice.

> In other words, we are waiting for
> https://bugzilla.gnome.org/show_bug.cgi?id=387832 to finally be fixed :)

Added to 0.9.8 tracker.

> If you want to remove the old Gentoo init script from networkmanager
> upstream, we are also fine with that; it's not much of an inconvenience for
> us, and networkmanager is your code, so the decision is up to you.

We are trying to open to a wider community. It's not a problem to maintain
a Gentoo-specific initscript. I would just prefer not to maintain it in two places, upstream and Gentoo patches.

So, if you thing this is a good idea, I'll remove it.