Created attachment 328196 [details] tboot 1.7.2 ebuild This ebuild adds the tboot vmm which is required for kernels and virtual machines which want to use the Intel TXT security feature. See for example: http://lwn.net/Articles/326747/
Hi, Thanks for the ebuild. A couple of comments Why filter-ldflags "-Wl,-O1" "-Wl,--as-needed"? Why MAKEOPTS="-j1"? In any case these must NOT be in global scope. They should be placed in src_compile. However I see no reason to do overwrite these variables. emake install is preferred over einstall It's better if you put all the docs in an array. If yo do that, calling 'default' in src_install will call emake install and install the docs for you
(In reply to comment #1) > Hi, > > Thanks for the ebuild. A couple of comments > > Why filter-ldflags "-Wl,-O1" "-Wl,--as-needed"? That is a leftover from the original ebuild I copied from an overlay. > Why MAKEOPTS="-j1"? Compiling failed otherwise. > In any case these must NOT be in global scope. They should be placed in > src_compile. However I see no reason to do overwrite these variables. OK, you're the expert. > emake install is preferred over einstall Okay but in this case the upstream Makefile does not install anything on the system but rather moves everything to ${S}/dist I any case, emake install or einstall with the upstream Makefile behaved strangely, namely installing everything in portage/ebuild.sh's $DISTDIR (foo/dist) instead of foo/image. I assume there are some namespace issues between the portage environment and the Makefiles usage of $D, $DESTDIR and $DISTDIR. Hence all the other do* stuff from ${S}/dist after einstall. > It's better if you put all the docs in an array. If yo do that, calling > 'default' in src_install will call emake install and install the docs for you I'm not sure what you mean by that. How would that array need to be named?
DOCS=(README FOOBAR TESTME) then the 'default' call in src_install will install the docs. I will create a new ebuild for reference
sys-boot/tboot has been in the tree for a while now.
