Bug 440286 – net-nds/rpcbind - add support for warm restarts of rpcbind daemon

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sean McGovern 2012-10-30 15:20:48 UTC]

Attached patches advertise and enable this functionality via a 'warmstarts' USE flag.

Also provides an rpcbind.socket and rpcbind.service for interaction with sys-apps/systemd.

[Comment 1 Sean McGovern 2012-10-30 15:28:57 UTC]

Created attachment 327788 [details, diff]
patch for rpcbind ebuild

[Comment 2 Sean McGovern 2012-10-30 15:30:22 UTC]

Created attachment 327790 [details, diff]
patch to disable warmstart advertisement in manpage and daemon

[Comment 3 Sean McGovern 2012-10-30 16:59:02 UTC]

Created attachment 327804 [details]
socket file for systemd

[Comment 4 Sean McGovern 2012-10-30 16:59:30 UTC]

Created attachment 327806 [details]
service file for systemd

[Comment 5 Sean McGovern 2012-10-30 17:11:44 UTC]

Created attachment 327808 [details, diff]
patch to rpcbind metadata.xml for new warmstarts USE flag

[Comment 6 Sean McGovern 2012-10-30 17:20:11 UTC]

The systemd service does not enable warmstarts by default. Should I add an einfo/ewarn to the ebuild for this?

I've already converted my setup to systemd, but I can also modifying the initscript if so desired. I would need someone else to test it, however.

[Comment 7 SpanKY 2012-10-30 20:43:09 UTC]

Comment on attachment 327804 [details]
socket file for systemd

i'm not interested in systemd and seems unrelated to warmstart.  do that in a sep bug so someone else can review it.

[Comment 8 SpanKY 2012-10-30 20:44:43 UTC]

Comment on attachment 327788 [details, diff]
patch for rpcbind ebuild

>+	use warmstarts && myconf+=" --with-statedir=${EPREFIX}/run/${PN}"

i don't think you need to make this conditional on USE=warmstarts

> src_install() {
> 	emake DESTDIR="${D}" install || die
> 	dodoc AUTHORS ChangeLog NEWS README

you converted to EAPI=4, so change these two lines to `default`

>-	newinitd "${FILESDIR}"/rpcbind.initd rpcbind || die
>-	newconfd "${FILESDIR}"/rpcbind.confd rpcbind || die
>+	newinitd "${FILESDIR}"/${PN}.initd ${PN} || die
>+	newconfd "${FILESDIR}"/${PN}.confd ${PN} || die

since you converted to EAPI=4, drop the '|| die'

[Comment 9 Sean McGovern 2012-10-30 21:36:43 UTC]

OK, will modify and re-send soon.

Thanks for reviewing. :)

[Comment 10 Sean McGovern 2012-10-30 22:21:24 UTC]

Created attachment 327836 [details, diff]
revised patch for rpcbind ebuild

[Comment 11 Sean McGovern 2012-10-30 22:22:40 UTC]

Created attachment 327838 [details]
OPTIONAL new confd with warmstart flag added

[Comment 12 Sean McGovern 2012-11-13 18:05:16 UTC]

*ping!*

[Comment 13 Sean McGovern 2013-01-10 20:33:08 UTC]

*ping^2*

[Comment 14 Sean McGovern 2013-03-28 17:06:29 UTC]

*ping^3!*

[Comment 15 Tim Harder 2014-01-30 05:10:46 UTC]

Added in 0.2.1. However since it's not enabled by default I didn't add a new default conf.d that enables it.

Also, the systemd stuff should be done in a different bug like mentioned previously.