Bug 439280 – app-emulation/vmware-modules-264.4 - missing return carriage in printk in VNetUserIfSetUplinkState() at vmnet-only/userif.c

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Evan Teran 2012-10-22 16:15:12 UTC]

Not 100% sure whether this belongs here or at vmware's bug tracker, so I figured I'd try here :-).

when looking at my dmesg I see lines like this:

userif-3: sent link up event.<7>bridge-eth1: disabling the bridge on dev down

Since things like <7> are typically the "level" of the message, this looks like 2 messages. In fact, often the second half is clearly from another module. So my assumption is that the first message is missing a return carriage.

Looking at the sources, the problem appears to be line 959 of file vmnet-only/userif.c.

   LOG(0, (KERN_NOTICE "userif-%d: sent link %s event.", 
           userIf->port.id, linkUp?"up":"down"));

has no newline :-).

I will be attaching a patch to this report which I believe addresses the issue.

Reproducible: Always

[Comment 1 Evan Teran 2012-10-22 16:15:38 UTC]

Created attachment 327154 [details, diff]
patch to add missing newline

[Comment 2 Andreas K. Hüttel 2013-12-27 16:34:59 UTC]

patch added, thx