Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 437546 - repoman commit: use same commit message for ebuild&manifest commits
Summary: repoman commit: use same commit message for ebuild&manifest commits
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 431026
  Show dependency tree
 
Reported: 2012-10-07 21:17 UTC by Michał Górny
Modified: 2012-10-15 02:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-10-07 21:17:42 UTC
Right now, the commit messages used for ebuild & Manifest commits in CVS differ (by repoman signature). However, considering that these two commits are closely bound, I believe that they could be merged into one. And that could happen if the messages were the same.

Thus, I'd like to request changing the repoman behavior to use the same commit message for ebuild & Manifest commits.
Comment 2 Zac Medico gentoo-dev 2012-10-08 23:29:55 UTC
This is fixed in 2.1.11.25 and 2.2.0_alpha136.
Comment 3 Brian Harring (RETIRED) gentoo-dev 2012-10-14 18:57:02 UTC
The request leveled here is whacky; the commit messages differing in text is fine (seriously, it is)- if the aesthetics is the complaint, then make the first commit message have the same key in the commit message.

Dropping the signing key information however, means that we reverse long term trend, and cvs->git migration no longer can convert that bit of data into a git footer.

Keep in mind that for cvs->Git, the complaint about differing messages has no bearing- the manifest double commit doesn't exist in git.

Reverse this change please; have both have the same commit message if you like, or differing, but the key needs to be in the commit message.
Comment 5 Zac Medico gentoo-dev 2012-10-14 19:49:58 UTC
(In reply to comment #3)
> if the aesthetics is the complaint, then make the
> first commit message have the same key in the commit message.

Okay, done:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=30f3a3fb492bf956d928352037e12d948a8a7a35
Comment 6 Zac Medico gentoo-dev 2012-10-15 00:31:09 UTC
This is fixed in 2.1.11.27 and 2.2.0_alpha138.
Comment 7 Brian Harring (RETIRED) gentoo-dev 2012-10-15 02:22:55 UTC
(In reply to comment #6)
> This is fixed in 2.1.11.27 and 2.2.0_alpha138.

Sweet; appreciate the turn around time (nothing worse than finding a day to be active on cvs2git, then being blocked) :)