Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 437332 - sys-process/psmisc-22.20 fails to build on selinux systems
Summary: sys-process/psmisc-22.20 fails to build on selinux systems
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: SELinux (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: SE Linux Bugs
Depends on:
Reported: 2012-10-05 17:51 UTC by Amadeusz Sławiński
Modified: 2012-10-09 04:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

build log (build.log,10.94 KB, text/plain)
2012-10-05 17:53 UTC, Amadeusz Sławiński
security_context_t scontext (psmisc-22.20-selinux.patch,1.12 KB, patch)
2012-10-05 19:38 UTC, iGentoo
Details | Diff
upstream's patch (pstree-selinux-fixup.patch,8.75 KB, patch)
2012-10-07 16:34 UTC, Jory A. Pratt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Amadeusz Sławiński 2012-10-05 17:51:31 UTC
It fails to emerge due to undeclared variable:

pstree.c: In function ‘fix_orphans’:
pstree.c:811:39: error: ‘scontext’ undeclared (first use in this function)
pstree.c:811:39: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [pstree.o] Error 1

from pstree in function fix_orphans(void):
    root = new_proc("?", ROOT_PID, 0, scontext);
#else                                /*WITH_SELINUX */
    root = new_proc("?", ROOT_PID, 0);

Reproducible: Always

Portage (hardened/linux/amd64/selinux, gcc-4.6.3, glibc-2.15-r3, 3.5.4-hardened-r2 x86_64)
System uname: Linux-3.5.4-hardened-r2-x86_64-Intel-R-_Core-TM-_i3_CPU_M_350_@_2.27GHz-with-gentoo-2.2
Timestamp of tree: Fri, 05 Oct 2012 17:00:01 +0000
app-shells/bash:          4.2_p37
dev-lang/python:          2.7.3-r2, 3.2.3-r1
dev-util/cmake:           2.8.9-r1
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.10.5
sys-apps/sandbox:         2.6
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.6, 1.12.4
sys-devel/binutils:       2.22.90
sys-devel/gcc:            4.6.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.6 (virtual/os-headers)
sys-libs/glibc:           2.15-r3
Repositories: gentoo x11 hardened-dev my_local_overlay
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA AdobeFlash-10.3 PUEL skype- google-talkplugin"
CFLAGS="-march=native -O3 -pipe"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.4/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O3 -pipe"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles news parallel-fetch protect-owned sandbox selinux sesandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en en_GB pl"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTDIR_OVERLAY="/var/lib/layman/x11 /var/lib/layman/hardened-development /usr/local/portage"
USE="X acpi alsa amd64 apache2 bash-completion berkdb bluetooth bzip2 cli consolekit cracklib crypt cups cxx dbus dri dvd gdbm gif gpm hardened iconv icu ipv6 jpeg justify mmx mng modules mp3 mudflap multilib mysql mysqli ncurses networkmanager nls nptl open_perms opengl openmp pam pax_kernel pcre png policykit pppd readline selinux session sse sse2 sse4_1 sse4_2 ssl ssse3 tcpd thunar tiff udev udisks unicode urandom usb v4l vaapi vdpau vim-syntax wacom wifi xft xinerama xtpax zlib zsh-completion" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_GB pl" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Comment 1 Amadeusz Sławiński 2012-10-05 17:53:23 UTC
Created attachment 325738 [details]
build log
Comment 2 iGentoo 2012-10-05 19:38:34 UTC
Created attachment 325760 [details, diff]
security_context_t scontext

I have the same problem.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2012-10-06 07:11:59 UTC
This reported to upstream bug tracking system at sourceforge yet?
Comment 4 Amadeusz Sławiński 2012-10-06 12:27:35 UTC
Comment 5 Sven Vermeulen (RETIRED) gentoo-dev 2012-10-06 20:47:14 UTC
I think most invocations towards scontext there can be changed to NULL. They're mostly referenced when no process exists or cannot be queried and the application creates a psmisc-process-structure (PROC) with unknown name ("?"). If it is for viewing purposes, it'll eventually hit out_string() which I believe will happily ignore a NULL (in the way that it exists gracefully without displaying any cruft).

You shouldn't take my word on it though - a patch to validate is always welcome ;-)
Comment 6 Jory A. Pratt gentoo-dev 2012-10-07 16:34:23 UTC
Created attachment 325930 [details, diff]
upstream's patch
Comment 7 Stan Sander 2012-10-09 02:07:43 UTC
emerges fine here after including upstreams patch from Jory.
Comment 8 SpanKY gentoo-dev 2012-10-09 04:31:55 UTC
should be all set now in the tree; thanks for the report!

Commit message: Add fix from upstream for building on selinux systems