Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 436402 - kernel-2.eclass - Print the value of PATCH_DEPTH actually used for patching rather than it's initial value.
Summary: kernel-2.eclass - Print the value of PATCH_DEPTH actually used for patching r...
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Kernel Miscellaneous
Depends on:
Reported: 2012-09-27 12:45 UTC by Eric F. GARIOUD
Modified: 2013-04-17 13:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

patch_depth.patch (file_436402.txt,2.44 KB, text/plain)
2013-04-12 15:45 UTC, Tom Wijsman (TomWij) (RETIRED)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric F. GARIOUD 2012-09-27 12:45:34 UTC
When patches are applied to the kernel, the screen systematically and always shows "Applying ${i/*\//} (-p${PATCH_DEPTH}+)" (line 986).

- That is to say the value of PATCH_DEPTH prior entering the while loop (line 987) in which different values for PATCH_DEPTH might be tested.
- That is to say not necessarily the value of PATCH_DEPTH used for actually applying the patch.

This, most of the time, results in the display of "... p(0)+" when, most of the times (genpatches, ck-patches...) these patches are actually applied for PATCH_DEPTH = 1

This might appear trivial and whoever playing with kernel source ebuilds is certainly well aware of this but... it does make the n00b needlessly suspecting some error was made at this point and desperately look for some error in his own code before... having to understand what kernel-2.eclass does...

No hardfeeling... I would have had to dig into kernel-2.eclass one day or another anyway...

Reproducible: Always
Comment 1 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-12 15:45:52 UTC
Created attachment 345392 [details]

This patch will be part of a series of patches that will be sent to the mailing lists and committed all at once to the tree in the near future.
Comment 2 Eric F. GARIOUD 2013-04-12 21:16:17 UTC
This patch does enable traces displaying much more valuable information.

Thanks a lot for this, Tom.
Comment 3 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-17 13:53:24 UTC
  17 Apr 2013; Tom Wijsman <> kernel-2.eclass:
  Added a warning after the variables that modifying other variables in
  the eclass is not supported, there is a chance that we will not fix
  resulting bugs. Fixes bug #421721.
  Clarify the default DESCRIPTION and make it not use versions, a
  directory with ebuilds that inherit this eclass may contain multiple
  versions and we also don't want to give the impression that a new
  directory needs to made if that's not the case. Fixes bug #445110.
  Clarified which patch depths are used in the normal output and error
  output when applying patches. Fixes bug #436402.
  Made sure .tmp_gas_check is created inside the temp folder, it
  accidentally created temp.tmp_gas_check instead. Fixes bug #336732.
  Make UNIPATCH_DOCS work again, install 0000_README document when
  using genpatches. Fixes bug #301478.