Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 436122 - net-dialup/ppp-2.4.5-r3 - Failed Patch: 80_all_eaptls-mppe-0.991-gentoo.patch !
Summary: net-dialup/ppp-2.4.5-r3 - Failed Patch: 80_all_eaptls-mppe-0.991-gentoo.patch !
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-24 17:16 UTC by cilly
Modified: 2014-01-20 16:04 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emergeinfo.txt,5.64 KB, text/plain)
2012-09-24 20:18 UTC, cilly
Details
80_all_eaptls-mppe-0.991-gentoo.patch.out (80_all_eaptls-mppe-0.991-gentoo.patch.out,34.86 KB, text/plain)
2012-09-24 20:18 UTC, cilly
Details
build.log (build.log,4.15 KB, text/plain)
2012-09-24 20:19 UTC, cilly
Details
build.log (build.log,4.09 KB, text/plain)
2012-10-06 21:10 UTC, Andrew Savchenko
Details
80_all_eaptls-mppe-0.991-gentoo.patch.out (80_all_eaptls-mppe-0.991-gentoo.patch.out,34.82 KB, text/plain)
2012-10-06 21:10 UTC, Andrew Savchenko
Details
emerge --info net-dialup/ppp (emerge.info,8.95 KB, text/plain)
2012-10-06 21:11 UTC, Andrew Savchenko
Details
environment (environment,123.46 KB, text/plain)
2012-10-06 21:11 UTC, Andrew Savchenko
Details
80_all_eaptls-mppe-0.991-gentoo.patch (80_all_eaptls-mppe-0.991-gentoo.patch,76.12 KB, patch)
2012-10-06 21:29 UTC, Andrew Savchenko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description cilly 2012-09-24 17:16:17 UTC
*   80_all_eaptls-mppe-0.991-gentoo.patch ...

 * Failed Patch: 80_all_eaptls-mppe-0.991-gentoo.patch !
 *  ( /var/tmp/portage/net-dialup/ppp-2.4.5-r3/work/patch/80_all_eaptls-mppe-0.991-gentoo.patch )
 *
 * Include in your bugreport the contents of:
 *
 *   /var/tmp/portage/net-dialup/ppp-2.4.5-r3/temp/80_all_eaptls-mppe-0.991-gentoo.patch.out

 * ERROR: net-dialup/ppp-2.4.5-r3 failed (prepare phase):
 *   Failed Patch: 80_all_eaptls-mppe-0.991-gentoo.patch!
 *
 * Call stack:
 *     ebuild.sh, line   85:  Called src_prepare
 *   environment, line 3208:  Called epatch '/var/tmp/portage/net-dialup/ppp-2.4.5-r3/work/patch'
 *   environment, line 1267:  Called die
 * The specific snippet of code:
 *               die "Failed Patch: ${patchname}!";
 *
 * If you need support, post the output of `emerge --info '=net-dialup/ppp-2.4.5-r3'`,
 * the complete build log and the output of `emerge -pqv '=net-dialup/ppp-2.4.5-r3'`.
 * The complete build log is located at '/var/tmp/portage/net-dialup/ppp-2.4.5-r3/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/net-dialup/ppp-2.4.5-r3/temp/environment'.
 * Working directory: '/var/tmp/portage/net-dialup/ppp-2.4.5-r3/work/ppp-2.4.5'
 * S: '/var/tmp/portage/net-dialup/ppp-2.4.5-r3/work/ppp-2.4.5'

>>> Failed to emerge net-dialup/ppp-2.4.5-r3, Log file:

>>>  '/var/tmp/portage/net-dialup/ppp-2.4.5-r3/temp/build.log'
 * 
 * The following package has failed to build or install:
 * 
 *  (net-dialup/ppp-2.4.5-r3::gentoo, ebuild scheduled for merge), Log file:
 *   '/var/tmp/portage/net-dialup/ppp-2.4.5-r3/temp/build.log'
 *
Comment 1 cilly 2012-09-24 17:35:51 UTC
Useflag which reproduces this issue:

eap-tls
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2012-09-24 18:32:00 UTC
 *
 * Include in your bugreport the contents of:
 *
 *   /var/tmp/portage/net-dialup/ppp-2.4.5-r3/temp/80_all_eaptls-mppe-0.991-gentoo.patch.out


And your `emerge --info' output too, please. Also, which version of sys-devel/patch do you have?
Comment 3 cilly 2012-09-24 20:18:03 UTC
Created attachment 324878 [details]
emerge --info
Comment 4 cilly 2012-09-24 20:18:49 UTC
Created attachment 324880 [details]
80_all_eaptls-mppe-0.991-gentoo.patch.out
Comment 5 cilly 2012-09-24 20:19:50 UTC
Created attachment 324882 [details]
build.log
Comment 6 cilly 2012-09-24 20:24:21 UTC
Comment on attachment 324880 [details]
80_all_eaptls-mppe-0.991-gentoo.patch.out

find /var/tmp/portage/net-dialup -iname "eap.c.rej" <<< file not found
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2012-09-25 02:58:08 UTC
(In reply to comment #6)
> Comment on attachment 324880 [details]
> /var/tmp/portage/net-dialup/ppp-2.4.5-r3/temp/80_all_eaptls-mppe-0.991-
> gentoo.patch.out
> 
> find /var/tmp/portage/net-dialup -iname "eap.c.rej" <<< file not found

epatch doesn't actually write those, but patch still says it does.

(In reply to comment #2)
> Also, which version of sys-devel/patch do you have?

Well?
Comment 8 cilly 2012-09-25 07:32:33 UTC
eix -e sys-devel/patch
[I] sys-devel/patch
     Available versions:  2.5.9 ~2.5.9-r1 2.6.1{tbz2} ~2.7 {{static test xattr}}
     Installed versions:  2.6.1{tbz2}(06:36:10 PM 08/14/2012)(-static -test)
     Homepage:            http://www.gnu.org/software/patch/patch.html
     Description:         Utility to apply diffs to files
Comment 9 Andrew Savchenko gentoo-dev 2012-10-06 21:08:22 UTC
The same problem, patch-2.7.1
Comment 10 Andrew Savchenko gentoo-dev 2012-10-06 21:10:35 UTC
Created attachment 325832 [details]
build.log
Comment 11 Andrew Savchenko gentoo-dev 2012-10-06 21:10:55 UTC
Created attachment 325834 [details]
80_all_eaptls-mppe-0.991-gentoo.patch.out
Comment 12 Andrew Savchenko gentoo-dev 2012-10-06 21:11:25 UTC
Created attachment 325836 [details]
emerge --info net-dialup/ppp
Comment 13 Andrew Savchenko gentoo-dev 2012-10-06 21:11:35 UTC
Created attachment 325838 [details]
environment
Comment 14 Andrew Savchenko gentoo-dev 2012-10-06 21:16:17 UTC
It fails because of the following chunk:

diff -Nru ppp-2.4.5.orig//pppd/eap.c ppp-2.4.5/pppd/eap.c
--- ppp-2.4.5.orig//pppd/eap.c  2009-11-16 23:26:07.000000000 +0100
+++ ppp-2.4.5/pppd/eap.c        2011-11-11 01:30:38.000000000 +0100
@@ -43,6 +43,11 @@
  * Based on draft-ietf-pppext-eap-srp-03.txt.
  */

+/*
+ * Modification by Beniamino Galvani, Mar 2005
+ * Implemented EAP-TLS authentication
+ */
+
 #define RCSID  "$Id: 80_all_eaptls-mppe-0.991-gentoo.patch,v 1.1 2012/08/10 04:12:45 vapier Exp $"

 /*

Obviously RCSID must be changed too. In current patch it is errorneously omitted.
Comment 15 Andrew Savchenko gentoo-dev 2012-10-06 21:28:49 UTC
The proper chuck would be:

@@ -43,7 +43,12 @@
  * Based on draft-ietf-pppext-eap-srp-03.txt.
  */

-#define RCSID  "$Id: eap.c,v 1.4 2004/11/09 22:39:25 paulus Exp $"
+/*
+ * Modification by Beniamino Galvani, Mar 2005
+ * Implemented EAP-TLS authentication
+ */
+
+#define RCSID  "$Id: 80_all_eaptls-mppe-0.991-gentoo.patch,v 1.1 2012/08/10 04:12:45 vapier Exp $"

 /*
  * TODO:
Comment 16 Andrew Savchenko gentoo-dev 2012-10-06 21:29:13 UTC
Created attachment 325840 [details, diff]
80_all_eaptls-mppe-0.991-gentoo.patch

working patch
Comment 17 Patryk Rzadzinski 2012-10-20 10:29:24 UTC
*bump* I have the same problem.
Comment 18 Evgeny 2012-11-09 04:06:18 UTC
(In reply to comment #16)
> Created attachment 325840 [details, diff] [details, diff]
> 80_all_eaptls-mppe-0.991-gentoo.patch
> 
> working patch

I have the same problem. I try to use this patch and ppp compiled, but it's still doesn't work with token (SafeNet or Alladin token)

/var/tmp/portage/net-dialup/ppp-2.4.5-r3/work/ppp-2.4.5/pppd/pppd call VPN 
using channel 9
Using interface ppp0
Connect: ppp0 <--> /dev/pts/3
sent [LCP ConfReq id=0x1 <asyncmap 0x0> <magic 0xb6cd8aac> <pcomp> <accomp>]
rcvd [LCP ConfReq id=0x0 <mru 1400> <auth eap> <magic 0x5dd67132> <pcomp> <accomp>]
sent [LCP ConfAck id=0x0 <mru 1400> <auth eap> <magic 0x5dd67132> <pcomp> <accomp>]
rcvd [LCP ConfAck id=0x1 <asyncmap 0x0> <magic 0xb6cd8aac> <pcomp> <accomp>]
rcvd [EAP Request id=0x40 Identity <No message>]
sent [EAP Response id=0x40 Identity <Name "user@domain.com">]
rcvd [EAP Request id=0x41 TLS --S]
MTU = 1386
calling get_eaptls_secret
calling eaptls_init_ssl
Found privatekey engine 'pkcs11'
Found privatekey identifier '39453945373335312d333545442d343031612d384637302d3238463636393036363042303a30'
Loading OpenSSL config file
Loading OpenSSL built-ins
Loading OpenSSL configured modules
Fatal signal 11
tcflush failed: Input/output error




I'am also have alt-linux sources of ppp and it's works correctly: 


/data/ppp-2.4.5/pppd/pppd call kl_vpn
using channel 10
Using interface ppp0
Connect: ppp0 <--> /dev/pts/3
sent [LCP ConfReq id=0x1 <asyncmap 0x0> <magic 0x306db163> <pcomp> <accomp>]
sent [LCP ConfReq id=0x1 <asyncmap 0x0> <magic 0x306db163> <pcomp> <accomp>]
rcvd [LCP ConfReq id=0x0 <mru 1400> <auth eap> <magic 0xa2b621b> <pcomp> <accomp>]
sent [LCP ConfAck id=0x0 <mru 1400> <auth eap> <magic 0xa2b621b> <pcomp> <accomp>]
rcvd [LCP ConfAck id=0x1 <asyncmap 0x0> <magic 0x306db163> <pcomp> <accomp>]
rcvd [EAP Request id=0x41 Identity <No message>]
sent [EAP Response id=0x41 Identity <Name "user@domain.com">]
rcvd [EAP Request id=0x42 TLS --S]
Found OpenSSL engine 'pkcs11'
Found engine identifier '39453945373335312d333545442d343031612d384637302d3238463636393036363042303a30'
Locating OpenSSL config file
Loading OpenSSL config file
Loading OpenSSL built-ins
Loading OpenSSL configured modules
Enabling OpenSSL auto engines
Loading OpenSSL 'pkcs11' engine support
Initialising engine
Loading private key '39453945373335312d333545442d343031612d384637302d3238463636393036363042303a30' from engine
Got the private key, adding it to SSL context
 -> Handshake: Client Hello
sent [EAP Response id=0x42 TLS --- ...]
rcvd [EAP Request id=0x42 TLS --S]
sent [EAP Response id=0x42 TLS --- ...]
rcvd [EAP Request id=0x42 TLS --S]
sent [EAP Response id=0x42 TLS --- ...]
rcvd [EAP Request id=0x43 TLS LM- ...]
sent [EAP Response id=0x43 TLS Ack]
rcvd [EAP Request id=0x44 TLS -M- ...]
sent [EAP Response id=0x44 TLS Ack]
rcvd [EAP Request id=0x45 TLS -M- ...]
sent [EAP Response id=0x45 TLS Ack]
rcvd [EAP Request id=0x46 TLS -M- ...]
sent [EAP Response id=0x46 TLS Ack]
rcvd [EAP Request id=0x47 TLS -M- ...]
sent [EAP Response id=0x47 TLS Ack]
rcvd [EAP Request id=0x48 TLS --- ...]
 <- Handshake: Server Hello
 <- Handshake: Certificate
certificate verify depth: 2
certificate verify depth: 2
certificate verify depth: 1
certificate verify depth: 0
Certificate CN: vpn.domain.com , peer name vpn.domain.com
 <- Handshake: Certificate Request
 <- Handshake: Server Hello Done
 -> Handshake: Certificate
 -> Handshake: Client Key Exchange
 -> Handshake: Certificate Verify
 -> ChangeCipherSpec
 -> Handshake: Finished
sent [EAP Response id=0x48 TLS LM- ...]
rcvd [EAP Request id=0x49 TLS Ack]
sent [EAP Response id=0x49 TLS -M- ...]
rcvd [EAP Request id=0x4a TLS Ack]
sent [EAP Response id=0x4a TLS --- ...]
rcvd [EAP Request id=0x4b TLS L-- ...]
 <- ChangeCipherSpec
 <- Handshake: Finished
sent [EAP Response id=0x4b TLS Ack]
rcvd [EAP Success id=0x4b]
EAP authentication succeeded
kernel does not support PPP filtering
sent [CCP ConfReq id=0x1 <mppe +H -M +S +L -D -C>]
rcvd [CCP ConfReq id=0xc <mppe +H -M +S -L -D -C>]
sent [CCP ConfAck id=0xc <mppe +H -M +S -L -D -C>]
rcvd [IPCP ConfReq id=0xd <addr 91.103.69.171>]
sent [IPCP TermAck id=0xd]
rcvd [CCP ConfNak id=0x1 <mppe +H -M +S -L -D -C>]
sent [CCP ConfReq id=0x2 <mppe +H -M +S -L -D -C>]
rcvd [CCP ConfAck id=0x2 <mppe +H -M +S -L -D -C>]
MPPE 128-bit stateless compression enabled
sent [IPCP ConfReq id=0x1 <compress VJ 0f 01> <addr MYIP>]
rcvd [IPCP ConfRej id=0x1 <compress VJ 0f 01>]
sent [IPCP ConfReq id=0x2 <addr MYIP>]
rcvd [IPCP ConfNak id=0x2 <addr MYVPNIP>]
sent [IPCP ConfReq id=0x3 <addr MYVPNIP>]
rcvd [IPCP ConfAck id=0x3 <addr MYVPNIP>]
rcvd [IPCP ConfReq id=0xe <addr VPNSERVERIP>]
sent [IPCP ConfAck id=0xe <addr VPNSERVERIP>]
local  IP address MYVPNIP
remote IP address VPNSERVERIP
Script /etc/ppp/ip-up started (pid 11964)
rcvd [CCP ConfReq id=0xf <mppe +H -M +S -L -D -C>]
MPPE disabled
Connect time 0.0 minutes.
Sent 0 bytes, received 10 bytes.
sent [LCP TermReq id=0x2 "MPPE disabled"]
sent [CCP ConfReq id=0x3 <mppe +H -M +S +L -D -C>]
sent [CCP ConfAck id=0xf <mppe +H -M +S -L -D -C>]
rcvd [LCP TermAck id=0x2 "MPPE disabled"]
Connection terminated.
Waiting for 2 child processes...
  script /etc/ppp/ip-up, pid 11964
  script /usr/sbin/pptp --loglevel 2 vpn.domain.com --nolaunchpppd, pid 11949
Script /usr/sbin/pptp --loglevel 2 vpn.domain.com --nolaunchpppd finished (pid 11949), status = 0x0
Script /etc/ppp/ip-up finished (pid 11964), status = 0x0
Script /etc/ppp/ip-down started (pid 11966)
Script /etc/ppp/ip-down finished (pid 11966), status = 0x0
Comment 19 Sergey Popov gentoo-dev 2014-01-20 13:45:37 UTC
Can not reproduce this on entirely stable system. Probably it was fixed some time ago. Reopen if the issue is there.
Comment 20 cilly 2014-01-20 16:04:15 UTC
Yes, issue seems solved for me, too.