Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 435252 - app-text/gv: please review prefix changes
Summary: app-text/gv: please review prefix changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Printing (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Printing Team
URL:
Whiteboard:
Keywords: Inclusion, InVCS, PATCH
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2012-09-16 19:40 UTC by Christoph Junghans (RETIRED)
Modified: 2012-09-16 20:27 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for gv-3.7.3-r1.ebuild (gv-3.7.3-r1.ebuild.patch,676 bytes, patch)
2012-09-16 19:40 UTC, Christoph Junghans (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2012-09-16 19:40:36 UTC
Created attachment 324028 [details, diff]
patch for gv-3.7.3-r1.ebuild

Changes:
- added prefix keywords
- install needs appdefaultsdir="${EPREFIX}/etc/X11/app-defaults", but default takes no arguments.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2012-09-16 20:00:15 UTC
Comment on attachment 324028 [details, diff]
patch for gv-3.7.3-r1.ebuild

- You forgot to remove DOCS after converting away from `default`
- Any app-defaults files installed by ebuilds must go to /usr/share/X11/app-defaults as per the longstanding policy eversince X.org 7.0 was introduced to Portage.  And /etc/X11/app-defaults/ is the place where you copy the config, and edit it there if needed.  Are you sure the install line is correct, now after hearing this?

- Samuli
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2012-09-16 20:11:32 UTC
(In reply to comment #1)
> Comment on attachment 324028 [details, diff] [details, diff]
> patch for gv-3.7.3-r1.ebuild
> 
> - You forgot to remove DOCS after converting away from `default`
I don't get it, default includes something like "dodoc README* ChangeLog AUTHORS NEWS TODO CHANGES".
> - Any app-defaults files installed by ebuilds must go to
> /usr/share/X11/app-defaults as per the longstanding policy eversince X.org
> 7.0 was introduced to Portage.  And /etc/X11/app-defaults/ is the place
> where you copy the config, and edit it there if needed.  Are you sure the
> install line is correct, now after hearing this?
You are right, but it seems app-defaults don't get installed anyway
$ equery f gv | grep app-defaults

So keeping default should be fine and we only need to add keywords.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2012-09-16 20:13:05 UTC
> So keeping default should be fine and we only need to add keywords.

cool. please proceed :)
Comment 4 Christoph Junghans (RETIRED) gentoo-dev 2012-09-16 20:27:22 UTC
(In reply to comment #3)
> > So keeping default should be fine and we only need to add keywords.
> 
> cool. please proceed :)
Done.