Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 434318 - qbittorrent 3.0.2 doesn't compile
Summary: qbittorrent 3.0.2 doesn't compile
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Markos Chandras (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-08 10:21 UTC by Tomasz Chilinski
Modified: 2012-09-09 13:53 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
qbittorrent 3.0.2 compile fix (qbittorrent-3.0.2-compile-fix.patch,398 bytes, text/plain)
2012-09-08 10:21 UTC, Tomasz Chilinski
Details
ebuild patch fixing qbittorrent 3.0.2 compilation (qbittorrent-3.0.2.ebuild.patch,363 bytes, patch)
2012-09-08 10:22 UTC, Tomasz Chilinski
Details | Diff
qbittorrent 3.0.2 compile fix (qbittorrent-3.0.2-compile-fix.patch,398 bytes, patch)
2012-09-08 10:23 UTC, Tomasz Chilinski
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Chilinski 2012-09-08 10:21:30 UTC
Created attachment 323202 [details]
qbittorrent 3.0.2 compile fix

There is unneeded line in torrentcontentmodelitem.cpp.
We need to patch qbittorrent before compile.
I've attached code patch and ebuild fix for qbittorrent 3.0.2.
Comment 1 Tomasz Chilinski 2012-09-08 10:22:38 UTC
Created attachment 323204 [details, diff]
ebuild patch fixing qbittorrent 3.0.2 compilation
Comment 2 Tomasz Chilinski 2012-09-08 10:23:30 UTC
Created attachment 323206 [details, diff]
qbittorrent 3.0.2 compile fix
Comment 3 Tomasz Chilinski 2012-09-08 10:31:40 UTC
Also fixed in current upstream where it's side effect of code refactoring.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2012-09-08 18:11:47 UTC
Compiles for me just fine. You need to provide your emerge --info. Also please show me the upstream commit if you have it around
Comment 5 Tomasz Chilinski 2012-09-08 18:29:25 UTC
(In reply to comment #4)
> Compiles for me just fine. You need to provide your emerge --info.

Look into my compile fix patch. Problem occurs for
<=net-libs/rb_libtorrent-0.15* and I'm almost sure that you
use net-libs/rb_libtorrent-0.16*.

> Also please show me the upstream commit if you have it around

As I said earlier: upstream developers have made big code refactoring,
so you won't find simple fix for this bug over there.
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2012-09-09 08:01:56 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Compiles for me just fine. You need to provide your emerge --info.
> 
> Look into my compile fix patch. Problem occurs for
> <=net-libs/rb_libtorrent-0.15* and I'm almost sure that you
> use net-libs/rb_libtorrent-0.16*.
> 
> > Also please show me the upstream commit if you have it around
> 
> As I said earlier: upstream developers have made big code refactoring,
> so you won't find simple fix for this bug over there.

qbittorrent-3.0.2 is ~testing. Therefore you also need to use the ~testing rb_libtorrent which is 0.16.X. Is there a reason you want to use the old one?
Comment 7 Davide Pesavento (RETIRED) gentoo-dev 2012-09-09 08:35:26 UTC
(In reply to comment #6)
> qbittorrent-3.0.2 is ~testing. Therefore you also need to use the ~testing
> rb_libtorrent which is 0.16.X.

That's what is generally recommended. But you should still raise the dep to >=0.16 to have a correct depgraph.
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2012-09-09 08:59:14 UTC
qbittorrent-3.0.X packages now depend on rb_libtorrent >= 0.16.3. Closing this bug as INVALID
Comment 9 Tomasz Chilinski 2012-09-09 11:10:47 UTC
> qbittorrent-3.0.2 is ~testing. Therefore you also need to use the ~testing
> rb_libtorrent which is 0.16.X. Is there a reason you want to use the old one?

That's "Everything or nothing" solution ;-)
You want to say if I use qbittorrent from ~testing, I should also use
xorg-server from ~testing?
Bumping requirement for qbittorrent in gentoo, although upstream qbittorent doesn't require rb_libtorrent 0.15.x, is kind of nonsense...
Comment 10 Markos Chandras (RETIRED) gentoo-dev 2012-09-09 13:53:53 UTC
(In reply to comment #9)
> > qbittorrent-3.0.2 is ~testing. Therefore you also need to use the ~testing
> > rb_libtorrent which is 0.16.X. Is there a reason you want to use the old one?
> 
> That's "Everything or nothing" solution ;-)
> You want to say if I use qbittorrent from ~testing, I should also use
> xorg-server from ~testing?
> Bumping requirement for qbittorrent in gentoo, although upstream qbittorent
> doesn't require rb_libtorrent 0.15.x, is kind of nonsense...

yes, if you use half of ~testing and half of stable packages, then this is an unsupported configuration for Gentoo and it has always been. I don't want to apply this custom patch without fist having upstream accepting it. I don't understand why you don't send your patch upstream. This patch is against 3.0.2 which should be similar with what upstream have in their git repo.