Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 433028 - media-gfx/gimp-2.8.2 - QA Notice: This package installs one or more .desktop files that do not pass validation.
Summary: media-gfx/gimp-2.8.2 - QA Notice: This package installs one or more .desktop ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Low minor (vote)
Assignee: Sebastian Pipping
URL: https://git.gnome.org/browse/gimp/com...
Whiteboard:
Keywords:
: 472304 (view as bug list)
Depends on:
Blocks: .desktop
  Show dependency tree
 
Reported: 2012-08-28 07:50 UTC by Ilya Gordeev
Modified: 2013-06-05 21:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Gordeev 2012-08-28 07:50:51 UTC
QA Notice: This package installs one or more .desktop files that do not
pass validation.

        /usr/share/applications/zzz-gimp.desktop: warning: value "application/postscript;application/pdf;image/bmp;image/g3fax;image/gif;image/x-fits;image/pcx;image/x-portable-anymap;image/x-portable-bitmap;image/x-portable-graymap;image/x-portable-pixmap;image/x-psd;image/x-sgi;image/x-tga;image/x-xbitmap;image/x-xwindowdump;image/x-xcf;image/x-compressed-xcf;image/x-gimp-gbr;image/x-gimp-pat;image/x-gimp-gih;image/tiff;image/jpeg;image/x-psp;image/png;image/x-icon;image/x-xpixmap;image/svg+xml;application/pdf;image/x-wmf;image/jp2;image/jpeg2000;image/jpx;image/x-xcursor;" for key "MimeType" in group "Desktop Entry" contains "application/pdf" more than once

Reproducible: Always
Comment 1 Sebastian Pipping gentoo-dev 2012-08-28 23:01:26 UTC
Hello Ilya,


that's probably both an easy and tough one:

 * File zzz.desktop is the renamed version of gimp.desktop.
   That's specific to Gentoo.

 * gimp.desktop is made from [gimp-2.8.2]/desktop/gimp.desktop.in.in
   and its @MIME_TYPES@ is filled during runtime of ./configure
   (which is generated from configure.ac at packaging time).

 * configure.ac has code to add mime type "application/pdf" twice, first by

     # The list of MIME types that are supported by plug-ins that \
     #   are compiled unconditionally:
     MIME_TYPES="application/postscript;application/pdf;[..]"

   and a second time by

     ## If both poppler and cairo-pdf are enabled then we have \
     #    complete PDF support
     if test "x$have_cairo_pdf" = xyes && test "x$have_poppler" = xyes; then
       MIME_TYPES="$MIME_TYPES;application/pdf"
     fi

Either "application/pdf" is truly independent of any build time options (i.e. it's unconditional) or it requires cairo and poppler.  Once we know which, one addition of "application/pdf" can be picked for removal.


Now the question is: How do we approach upstream about it, best?
To make them want to fix it would be cool to offer

 - a demo minimal .desktop file and the command line to trigger this
   very warning

 - ideally, a rationale why this is relevant to them beyond just killing the
   warning for us.

Any help would on that end would rock.  Have you opened bugs at GNOME's bugzilla before?
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2013-06-05 13:46:34 UTC
*** Bug 472304 has been marked as a duplicate of this bug. ***
Comment 3 Sebastian Pipping gentoo-dev 2013-06-05 21:46:54 UTC
+  05 Jun 2013; Sebastian Pipping <sping@gentoo.org> gimp-2.8.4.ebuild,
+  +files/gimp-2.8.4-valid-desktop-file.patch:
+  Fix duplicate PDF MIME type in .desktop file with upstream patch (bug
+  #433028)
+