Bug 430608 – cmake-utils.eclass: add support for dev-util/ninja

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Christoph Junghans (RETIRED) 2012-08-09 14:57:35 UTC]

I added a version of cmake-utils.eclass to science overlay which allows to choose the makefile generator via CMAKE_MAKEFILE_GENERATOR.

CMAKE_MAKEFILE_GENERATOR="ninja" will use dev-util/ninja instead of sys-devel/make, which makes the build a bit faster. make is the default and the fail-back if dev-util/ninja is not installed.

sci-chemistry/gromacs-4.6.9999 is a example.

[Comment 1 Johannes Huber (RETIRED) 2012-08-10 08:00:51 UTC]

Created attachment 320842 [details]
cmake-ninja-support.diff

[Comment 2 Johannes Huber (RETIRED) 2012-08-10 08:04:21 UTC]

Thanks. I put it on the next agenda meeting, will be discussed.

[Comment 3 Christoph Junghans (RETIRED) 2012-08-22 22:42:38 UTC]

(In reply to comment #2)
> Thanks. I put it on the next agenda meeting, will be discussed.
What was the outcome of the meeting?

[Comment 4 Johannes Huber (RETIRED) 2012-08-23 09:20:40 UTC]

(In reply to comment #3)
> What was the outcome of the meeting?

KDE team meeting summary [1]
> <snip>
> 5b. Bug 430608: cmake-utils.eclass: add support for dev-util/ninja
> It was decided to apply the patch and make building with ninja possible; 
> however, if the build fails a message about using an unsupported backend
> should be logged (if possible).
> </snip>

The raw patch is now imported to kde overlay for testing.

> if the build fails a message about using an unsupported backend
> should be logged (if possible).

Not done yet.

[1] http://www.gentoo.org/proj/en/desktop/kde/meeting-logs/kde-project-meeting-summary-20120816.txt

[Comment 5 Christoph Junghans (RETIRED) 2012-08-23 15:26:55 UTC]

(In reply to comment #4)
> (In reply to comment #3)
> > What was the outcome of the meeting?
> 
> KDE team meeting summary [1]
> > <snip>
> > 5b. Bug 430608: cmake-utils.eclass: add support for dev-util/ninja
> > It was decided to apply the patch and make building with ninja possible; 
> > however, if the build fails a message about using an unsupported backend
> > should be logged (if possible).
> > </snip>
> 
> The raw patch is now imported to kde overlay for testing.
Great.
> 
> > if the build fails a message about using an unsupported backend
> > should be logged (if possible).
> 
> Not done yet.
Feel free to state in the message that the bug reports should be assigned to me.

> 
> [1]
> http://www.gentoo.org/proj/en/desktop/kde/meeting-logs/kde-project-meeting-
> summary-20120816.txt

[Comment 6 Christoph Junghans (RETIRED) 2012-08-27 00:18:33 UTC]

Created attachment 322334 [details, diff]
some minor fixes for install with ninja

[Comment 7 Johannes Huber (RETIRED) 2012-09-05 21:29:43 UTC]

(In reply to comment #6)
> Created attachment 322334 [details, diff] [details, diff]
> some minor fixes for install with ninja

Thanks, pushed.

http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=commit;h=5371d54aec29e4610e65ad1da052b6da423d633c

[Comment 8 Michael Palimaka (kensington) 2012-09-20 10:33:28 UTC]

Thanks, moved to the tree.

+  20 Sep 2012; Michael Palimaka <[e-mail]> cmake-utils.eclass:
+  Add support for the ninja build system wrt bug #430608. Improve prefix
+  support wrt bug #434086.