Bug 430090 – gnome-base/libglade: please review prefix changes

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Christoph Junghans (RETIRED) 2012-08-05 21:33:46 UTC]

Created attachment 320520 [details, diff]
patch for libglade-2.6.4.ebuild

Trivial changes and one tweak for Solaris.

[Comment 1 Gilles Dartiguelongue (RETIRED) 2012-08-08 12:53:56 UTC]

The patch is ok but I have one question, wouldn't it be better if configure had AC_USE_SYSTEM_EXTENSIONS instead of defining it by hand ?

The package already does autoreconf so we would not loose any time but have the same autofoo for all platforms. What do you think ?

[Comment 2 Fabian Groffen 2012-08-08 13:05:44 UTC]

works for me, but we should try first if that is sufficient

[Comment 3 Christoph Junghans (RETIRED) 2012-08-08 16:56:01 UTC]

(In reply to comment #1)
> The patch is ok but I have one question, wouldn't it be better if configure
> had AC_USE_SYSTEM_EXTENSIONS instead of defining it by hand ?
> 
> The package already does autoreconf so we would not loose any time but have
> the same autofoo for all platforms. What do you think ?
This solution has been tested for a while, that I why I prefer to add this one to the ebuild.

I will open an upstream bug about that, so that it will be fixed in the next version.

[Comment 4 Fabian Groffen 2012-08-08 17:00:33 UTC]

without it:

libtool: compile:  i386-pc-solaris2.10-gcc -DHAVE_CONFIG_H -I. -I.. -DG_LOG_DOMAIN=\"libglade\" -I.. -pthread -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -I/Library/Gentoo/usr/include/libxml2 -I/Library/Gentoo/usr/include/atk-1.0 -I/Library/Gentoo/usr/include/glib-2.0 -I/Library/Gentoo/usr/lib/glib-2.0/include -I/Library/Gentoo/usr/include/gtk-2.0 -I/Library/Gentoo/usr/lib/gtk-2.0/include -I/Library/Gentoo/usr/include/cairo -I/Library/Gentoo/usr/include/gdk-pixbuf-2.0 -I/Library/Gentoo/usr/include/pango-1.0 -I/Library/Gentoo/usr/include/pixman-1 -I/Library/Gentoo/usr/include/freetype2 -I/Library/Gentoo/usr/include/libpng15 -DGLADE_LIBDIR=\"/Library/Gentoo/usr/lib\" -DGLADE_PREFIX=\"/Library/Gentoo/usr\" -march=core2 -O3 -pipe -Wall -std=c9x -MT glade-init.lo -MD -MP -MF .deps/glade-init.Tpo -c glade-init.c  -fPIC -DPIC -o .libs/glade-init.o
In file included from /Library/Gentoo/usr/include/glib-2.0/glib/gbacktrace.h:35:0,
                 from /Library/Gentoo/usr/include/glib-2.0/glib.h:36,
                 from ../glade/glade-xml.h:25,
                 from glade-xml.c:28:
/usr/include/signal.h:201:1: error: unknown type name ‘sigset_t’
In file included from /Library/Gentoo/usr/include/glib-2.0/glib/gbacktrace.h:35:0,
                 from /Library/Gentoo/usr/include/glib-2.0/glib.h:36,
                 from /Library/Gentoo/usr/include/glib-2.0/gobject/gbinding.h:30,
                 from /Library/Gentoo/usr/include/glib-2.0/glib-object.h:25,
                 from /Library/Gentoo/usr/include/glib-2.0/gio/gioenums.h:30,
                 from /Library/Gentoo/usr/include/glib-2.0/gio/giotypes.h:30,
                 from /Library/Gentoo/usr/include/glib-2.0/gio/gio.h:28,
                 from /Library/Gentoo/usr/include/gtk-2.0/gdk/gdkapplaunchcontext.h:30,
                 from /Library/Gentoo/usr/include/gtk-2.0/gdk/gdk.h:32,
                 from /Library/Gentoo/usr/include/gtk-2.0/gtk/gtk.h:32,
                 from glade-gtk.c:36:
/usr/include/signal.h:201:1: error: unknown type name ‘sigset_t’
...

[Comment 5 Alexandre Rostovtsev (RETIRED) 2012-08-09 01:30:49 UTC]

(In reply to comment #1)
> I will open an upstream bug about that, so that it will be fixed in the next
> version.

I believe there will be no next version. Libglade has long been deprecated, see https://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder. The last commit in libglade's git repository was in January 2010. And reporting a bug would be difficult since the libglade component has been removed from the gnome bugzilla.

[Comment 6 Fabian Groffen 2012-08-09 16:50:34 UTC]

http://tinderbox.dev.gentoo.org/misc/rindex/gnome-base/libglade
suggests there is still a lot that uses it :(

[Comment 7 Christoph Junghans (RETIRED) 2012-08-09 17:24:52 UTC]

(In reply to comment #5)
> (In reply to comment #1)
> > I will open an upstream bug about that, so that it will be fixed in the next
> > version.
> 
> I believe there will be no next version. Libglade has long been deprecated,
> see https://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder. The last
> commit in libglade's git repository was in January 2010. And reporting a bug
> would be difficult since the libglade component has been removed from the
> gnome bugzilla.
I reported the problem to James, the author of libglade.

@gnome-herd: Let me know if you prefer a patch for configure.in to call 
AC_USE_SYSTEM_EXTENSIONS or the current solution and I will prepare the change.

[Comment 8 Gilles Dartiguelongue (RETIRED) 2012-08-09 18:03:01 UTC]

I think the configure patch is the way to go. It should make the build behave as closely as possible for all platforms :)

[Comment 9 Christoph Junghans (RETIRED) 2012-08-10 05:52:29 UTC]

Created attachment 320836 [details, diff]
patch for libglade-2.6.4.ebuild

(In reply to comment #8)
> I think the configure patch is the way to go. It should make the build
> behave as closely as possible for all platforms :)
Done.

[Comment 10 Christoph Junghans (RETIRED) 2012-08-10 05:53:32 UTC]

Created attachment 320838 [details, diff]
enable extension in configure.ac

[Comment 11 Christoph Junghans (RETIRED) 2012-09-04 01:11:18 UTC]

@Gnome: ping!

[Comment 12 Pacho Ramos 2012-09-11 19:52:28 UTC]

(In reply to comment #11)
> @Gnome: ping!

Looks like nobody had time to look at this yet, sorry for the inconvenience, will see if I am able to in upcoming days :|

[Comment 13 Alexandre Rostovtsev (RETIRED) 2012-09-12 06:13:50 UTC]

Fixed, thanks.

>  12 Sep 2012; Alexandre Rostovtsev <[e-mail]>
>  libglade-2.6.4.ebuild, +files/libglade-2.6.4-enable-extensions.patch:
>  Enable prefix support; bug #430090, thanks to Christoph Junghans and Gilles
>  Dartiguelongue.