Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 428420 - sys-devel/crossdev-20120305 claims to use the last overlay from PORTDIR_OVERLAY but actually uses the first
Summary: sys-devel/crossdev-20120305 claims to use the last overlay from PORTDIR_OVERL...
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Embedded Gentoo Team
Keywords: PATCH
Depends on:
Reported: 2012-07-28 12:22 UTC by W. Trevor King
Modified: 2012-07-30 03:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Patch fixing crossdev implementation to match documentation (crossdev-overlay.patch,470 bytes, text/plain)
2012-07-28 12:22 UTC, W. Trevor King

Note You need to log in before you can comment on or make changes to this bug.
Description W. Trevor King 2012-07-28 12:22:00 UTC
Created attachment 319512 [details]
Patch fixing crossdev implementation to match documentation

The crossdev code:



  $ A="1 2 3"
  $ echo "${A%% *}"
  $ echo "${A##* }"

With a fixed implementation, Layman users could use their default config:

  $ tail -n2 /etc/portage/make.conf
  source /var/lib/layman/make.conf
  $ cat /var/lib/layman/make.conf 

to install into /usr/local/portage, which is nicer than clobbering the abc (or whatever) overlay, or making them rewrite their main make.conf.

I've attached a patch with the fix.
Comment 1 W. Trevor King 2012-07-28 12:25:24 UTC
I forgot to explain why I expect crossdev to use the last overlay.  There's the comment in the crossdev code directly above the patched lines:

  # see if user told us where to write things, otherwise
  # install our stuff to the last overlay in the list

And the help message:

  $ crossdev --help | grep -A1 oO
    -oO, --ov-output path    Overlay to write crossdev package links
                                [default: last from --overlays list]
Comment 2 SpanKY gentoo-dev 2012-07-30 03:01:38 UTC
the crossdev code has always picked the first overlay.  better to fix the documentation than to change the behavior.;a=commitdiff;h=e1e09a9a671c9c7c55a0e853d4f562472f8332f0