Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 427862 - sys-apps/portage should not install an /etc/make.globals symlink
Summary: sys-apps/portage should not install an /etc/make.globals symlink
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 431026
  Show dependency tree
 
Reported: 2012-07-24 11:43 UTC by Maxim Kammerer
Modified: 2012-08-11 23:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Kammerer 2012-07-24 11:43:42 UTC
Judging from an old commit, the symlink is never used:
http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commitdiff;h=133bdfe6d497d3e138512a777ddfee2c3aff1393

Removing it does not seem to have any effect.

The following code in the ebuild can also go away:

    if [ -f "${ROOT}/etc/make.globals" ]; then
        rm "${ROOT}/etc/make.globals"
    fi
(no idea why this does not remove the symlink)

    if [[ ! -L "${ROOT}/etc/make.globals" && -f "${ROOT}/etc/make.globals" ]]; then
        rm "${ROOT}/etc/make.globals"
    fi
(in newer ebuilds - explicitly does not remove if symlink)
Comment 1 Zac Medico gentoo-dev 2012-07-24 18:26:02 UTC
Yeah, anything that uses it can just be fixed to use /usr/share/portage/config/make.globals directly.
Comment 2 Zac Medico gentoo-dev 2012-07-24 19:18:54 UTC
This is fixed in git:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=efb58888bc3900d42c24db9f7ff9f820e93eeb57

I've also removed the code /etc/make.globals symlink code from portage-9999.ebuild.
Comment 3 Zac Medico gentoo-dev 2012-08-11 23:47:22 UTC
This is fixed in 2.1.11.10 and 2.2.0_alpha121.