Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 425196 - net-proxy/adzapper needs flush.pl (removed from dev-lang/perl-5.16.0)
Summary: net-proxy/adzapper needs flush.pl (removed from dev-lang/perl-5.16.0)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Network Proxy Developers (OBSOLETE)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: perl-5.16
  Show dependency tree
 
Reported: 2012-07-07 21:50 UTC by Alexandre
Modified: 2013-03-18 11:57 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Convert flush.pl usage to IO::Handle flush (adzapper-20080508-flush.patch,2.39 KB, patch)
2012-07-08 17:01 UTC, Brennan Shacklett
Details | Diff
Update ebuild to include patch and use src_prepare (adzapper-20080508-flush.ebuild.patch,723 bytes, patch)
2012-07-08 17:04 UTC, Brennan Shacklett
Details | Diff
Convert adzapper-20110915 to use IO::Handle (adzapper-20110915-flush.patch,2.40 KB, patch)
2012-09-30 03:56 UTC, Brennan Shacklett
Details | Diff
adzapper-20110915-r1.ebuild.hacked (adzapper-20110915-r1.ebuild,1.61 KB, application/octet-stream)
2012-09-30 11:22 UTC, Kamen Dokov
Details
adzapper-20110915-r1.ebuild.hacked.diff (adzapper-20110915-r1.ebuild.hacked.diff,231 bytes, text/plain)
2012-09-30 11:24 UTC, Kamen Dokov
Details
Update new ebuild to use patch (adzapper-20110915-r1.ebuild.patch,619 bytes, patch)
2012-09-30 17:26 UTC, Brennan Shacklett
Details | Diff
The final edition of adzapper-20110915-r1.ebuild (adzapper-20110915-r1.ebuild,1.54 KB, application/octet-stream)
2012-09-30 19:53 UTC, Kamen Dokov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre 2012-07-07 21:50:14 UTC
With dev-lang/perl-5.16.0 installed I found a issue to use adzapper + squid.

So, downgrading to dev-lang/perl-5.12.4-r2 solved for me but not the issue in perl-5.16.0.

P.S. I don't know nothing about Perl.

Reproducible: Always

Steps to Reproduce:
1. Upgrade perl to 5.16.0 version;
2. Try to run any script that need flush.pl like adzapper (squid_redirect)

Actual Results:  
Using adzapper + squid as exemple: 

Can't locate flush.pl in @INC (@INC contains: /etc/perl /usr/local/lib64/perl5/5.16.0/x86_64-linux /usr/local/lib64/perl5/5.16.0 /usr/lib64/perl5/vendor_perl/5.16.0/x86_64-linux /usr/lib64/perl5/vendor_perl/5.16.0 /usr/lib64/perl5/5.16.0/x86_64-linux /usr/lib64/perl5/5.16.0 .) at /etc/adzapper/squid_redirect line 34.

Expected Results:  
Run the script property.

Portage 2.1.11.5 (default/linux/amd64/10.0/desktop/gnome, gcc-4.6.3, glibc-2.15-r2, 3.4.4-gentoo x86_64)
=================================================================
                        System Settings
=================================================================
System uname: Linux-3.4.4-gentoo-x86_64-Intel-R-_Pentium-R-_Dual_CPU_T3400_@_2.16GHz-with-gentoo-2.1
Timestamp of tree: Sat, 07 Jul 2012 20:15:01 +0000
ccache version 3.1.7 [enabled]
app-shells/bash:          4.2_p29
dev-java/java-config:     2.1.12
dev-lang/python:          2.7.3-r2, 3.2.3-r1
dev-util/ccache:          3.1.7
dev-util/cmake:           2.8.8-r3
dev-util/pkgconfig:       0.26
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.10.5
sys-apps/sandbox:         2.6
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.11.5, 1.12.1
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.6.3
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.4 (virtual/os-headers)
sys-libs/glibc:           2.15-r2
Repositories: gentoo sunrise lcd-filtering
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -march=native -pipe -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -march=native -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs candy ccache config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles news parallel-fetch parse-eapi-ebuild-head protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://gentoo.c3sl.ufpr.br/gentoo/ http://gentoo.c3sl.ufpr.br/ ftp://ftp.las.ic.unicamp.br/pub/gentoo/ http://www.las.ic.unicamp.br/pub/gentoo/ http://gentoo.lcc.ufmg.br/ ftp://mirrors.localhost.net.ar/pub/mirrors/gentoo http://gentoo.localhost.net.ar/ ftp://distro.ibiblio.org/pub/linux/distributions/gentoo/ http://distro.ibiblio.org/pub/linux/distributions/gentoo/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en"
MAKEOPTS="-j3 -s"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/sunrise /var/lib/layman/lcd-filtering"
SYNC="rsync://rsync.samerica.gentoo.org/gentoo-portage/"
USE="7Zip X a52 aac acl acpi alsa amd64 audiofile bash-completion berkdb branding bzip2 cairo caps cdda cddb cdparanoia cdr cli colord consolekit cracklib crypt css cups cxx dbus dga dri dts dvd dvdr eds encode evo exif fam ffmpeg firefox flac foomaticdb ftp gdbm gif gnome gnome-keyring gnome-online-accounts gnutls gpm gstreamer gtk gtk3 iconv imagemagick imap jabber java jpeg lame latex lcms libcanberra libnotify lm_sensors lzma lzo mad matroska minimal mmx mng modules mp3 mp4 mpd mpeg mudflap multilib musepack musicbrainz nautilus ncurses networkmanager nls nptl nsplugin nvidia offensive ogg opengl openmp pam pango pcre pdf png policykit ppds pppd pulseaudio quicktime readline samba schoredinger sdl session socialweb spell sse sse2 sse3 ssl ssse3 startup-notification svg syslog tcpd theora threads tiff truetype udev udisks unicode upower usb v4l vdpau vim-syntax vorbis wavpack wifi x264 xcb xml xorg xv xvid zlib" ALSA_CARDS="hda-intel loopback" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" APACHE2_MPMS="prefork" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
USE_PYTHON="2.7"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

dev-lang/perl-5.12.4-r2 was built with the following:
USE="berkdb gdbm (multilib) -build -debug -doc -ithreads"
Comment 1 Rafał Mużyło 2012-07-08 02:38:04 UTC
perldoc perl5120delta
perldoc perl5160delta

so not quite a bug - at least not in perl.
Comment 2 Brennan Shacklett 2012-07-08 17:01:58 UTC
Created attachment 317588 [details, diff]
Convert flush.pl usage to IO::Handle flush

This patch removes the use of flush.pl in adzapper and replaces it with IO::Handle's flush (and autoflush).
Comment 3 Brennan Shacklett 2012-07-08 17:04:12 UTC
Created attachment 317590 [details, diff]
Update ebuild to include patch and use src_prepare

This patches the adzapper-20080508 ebuild to include the patch, it also changes it to use EAPI=4 so src_prepare can be used.
Comment 4 Alexandre 2012-07-27 17:51:44 UTC
The patch for squid_redirect is perfect working here. ;-D

Thanks Brennan Shacklett!!!
Comment 5 Kamen Dokov 2012-09-29 21:43:32 UTC
Dear Brennan Shacklett,
Can you make same thing with adzapper-20110915-r1, please? :)
Comment 6 Brennan Shacklett 2012-09-30 03:56:42 UTC
Created attachment 325354 [details, diff]
Convert adzapper-20110915 to use IO::Handle

The exact same patch essentially, they just changed the name of squid_redirect in the sources.
Comment 7 Kamen Dokov 2012-09-30 11:22:41 UTC
Created attachment 325366 [details]
adzapper-20110915-r1.ebuild.hacked

Dear Brennan Shacklett,
Can you review my hack of the official ebuild, please?
It seems to work, but my bash-scripting skills are non existent ;)
I'll upload "diff" also.
Comment 8 Kamen Dokov 2012-09-30 11:24:11 UTC
Created attachment 325368 [details]
adzapper-20110915-r1.ebuild.hacked.diff

diff adzapper-20110915-r1.ebuild.old adzapper-20110915-r1.ebuild.new >> adzapper-20110915-r1.ebuild.hacked.diff
Comment 9 Brennan Shacklett 2012-09-30 17:26:44 UTC
Created attachment 325396 [details, diff]
Update new ebuild to use patch

All I had to do was add the inherit eutils line and the epatch line, I don't think you should need to mess around with $S or using cd to switch around in the sources. Here is the patch I used.
Comment 10 Kamen Dokov 2012-09-30 19:51:37 UTC
(In reply to comment #9)
> Created attachment 325396 [details, diff] [details, diff]
> Update new ebuild to use patch
> 
> All I had to do was add the inherit eutils line and the epatch line, I don't
> think you should need to mess around with $S or using cd to switch around in
> the sources. Here is the patch I used.

Yes!
That was it! Thank you!
I knew it was something simple ;)
K.I.S.S. principle rules, as always!
Comment 11 Kamen Dokov 2012-09-30 19:53:33 UTC
Created attachment 325408 [details]
The final edition of adzapper-20110915-r1.ebuild
Comment 12 Torsten Veller (RETIRED) gentoo-dev 2013-03-18 11:57:39 UTC
Fixed in net-proxy/adzapper-20110915-r2

Thanks