Portage 2.2.0_alpha110 (default/linux/amd64/10.0, gcc-4.7.1, glibc-2.15-r2, 3.4.2-hardened x86_64)
System uname: Linux-3.4.2-hardened-x86_64-AMD_Opteron-TM-_Processor_6272-with-gentoo-2.1
Timestamp of tree: Sat, 16 Jun 2012 07:30:01 +0000
dev-lang/python: 2.7.3-r2, 3.2.3-r1
sys-devel/autoconf: 2.13, 2.69
sys-devel/automake: 1.9.6-r3, 1.11.5, 1.12.1
sys-devel/gcc: 4.5.3-r2, 4.7.1
sys-kernel/linux-headers: 3.4 (virtual/os-headers)
CFLAGS="-O2 -pipe -ggdb -march=native -ftracer"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -ggdb -march=native -ftracer"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles news parallel-fetch parse-eapi-ebuild-head protect-owned sandbox sfperms strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
USE="3dnow 3dnowex acl amd64 berkdb bzip2 cli cracklib crypt cups cxx dri ffmpeg fortran gdbm gpm iconv ipv6 mmx modules mudflap multilib ncurses nls nptl openmp pam pcre pppd qt3support readline session sse sse2 sse3 sse4 ssl ssse3 tcpd unicode vhosts xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 jruby ruby19 ree18" USERLAND="GNU" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Standard solution would apply: remove the macro, pass -DPROTOTYPES to cppflags...
But it seems that it's used only in src/prototypes.h, so you could simply patch that file.
* Include in your bugreport the contents of:
(In reply to comment #2)
> * Include in your bugreport the contents of:
> * /tmp/portage/app-arch/lha-114i-r7/temp/aclocal.out
It's already included - the files are cat-ed into a single one.
Uh, Rafal, AM_C_PROTOTYPES is not even defining PROTOTYPES, AC_C_PROTOTYPES is (which is probably what one wants to call at that point, it's not declared yet afaict).
*it's not declared deprecated yet.
(In reply to comment #5)
> *it's not declared deprecated yet.
sort of wrong - from automake 1.11 (/usr/share/automake-1.11/protos.m4)
[$0: automatic de-ANSI-fication support is deprecated])
if test "$ac_cv_prog_cc_stdc" != no; then
# Ensure some checks needed by ansi2knr itself.
in 1.12 it's just:
[AC_FATAL([automatic de-ANSI-fication support has been removed])])
obviously it does define PROTOTYPES, due to AC_REQUIRE.
It's not a particular macro, that's deprecated, it's whole de-ANSI-fication.
Repeating myself (with the correction applied):
Uh, Rafal, AM_C_PROTOTYPES is not even defining PROTOTYPES, AC_C_PROTOTYPES is (which is probably what one wants to call at that point, it's not declared deprecated yet afaict).
Read me again, carefully.
AM_C_PROTOTYPES (AM!) is deprecated in 1.11 and gone in 1.12.
AC_C_PROTOTYPES (AC!) is not deprecated, it's provided by autoconf (not automake) and defines PROTOTYPES.
See http://www.flameeyes.eu/autotools-mythbuster/forwardporting/automake.html as well.
Please don't just add -DPROTOTYPES magically, as we'll lose track of it altogether otherwise.
While *technically* not deprecated, 'info autoconf' on AC_C_PROTOTYPES:
-- Macro: AC_C_PROTOTYPES:
This macro is obsolescent, as current C compilers support
prototypes. New programs need not use this macro.
so while I'm not autoconf upstream, so can't say for sure, most likely the only reason this macro wasn't already deprecated was... automake.
Obsolete is different from deprecated — unfortunately.
My only point though is I'd prefer replacing the AM macro with the AC macro instead of using -DPROTOTYPES — if you want to get rid of the macro altogether, then simply remove the _need_ for -DPROTOTYPE at once (who the hell still uses ANSI C?!).
As for your page - thanks for doing the work, but in this particular case you're digging too deep into implementation.
The only *public* effect of AM_C_PROTOTYPES (besides those from AC_C_PROTOTYPES) was setting ANSI2KNR vars/rules. The other two were private and only for benefit of ansi2knr.c.
(btw, you've made a slight typo in the new block)
I know that was the intention of automake.
On the other hand I know that half the time things are done as side effects, somebody _is_ relying on said side effects.
I've seen more than once a macro being slimmed down causing miscompilation because one test it was doing was relied upon, but never made explicit.
...but now, that I've read that paragraph again, I see that you've got the order wrong - it's ANSI C, that was the *new* standard, K&R was the initial C implementation and ansi2knr from the very start was provided for backward compatibility.
Sigh that one I always get wrong (used to think about _ISO_ C as the current one). But we're swamping Jared with information he doesn't care about, can we just stick with:
- don't just define -DPROTOTYPES;
- if you're in touch with lha upstream, make them drop the whole reliance on PROTOTYPES define;
- make sure that the package is not relying on other macros called by AM_C_PROTOTYPES (namely the AC_HEADER_STDC and AC_CHECK_HEADERS([string.h]);
- replace AM_C_PROTOTYPES with AC_C_PROTOTYPES.
:lol: "if you're in touch with lha upstream"...
the one, that hasn't released a thing since 2006/10/16 (even if there was a bit work done in the repo http://sourceforge.jp/projects/lha/scm/git/lha/) ?
Also, I neither speak nor read Japanese (can barely work with rikai.com guesses).
Besides, AFAICT, the upstream simply ran autoscan at some point back in 2001.
I really don't care to know the details of projects I don't maintain. Whether there is an upstream or not it's of very little interest to me. If needed fork it, or whatever.
Just do it properly and not with a partial hack as you suggested to begin with.
Diego, I suppose there are no direct replacement for AM_C_PROTOTYPES, right?
People have been telling me to just drop it and append -DPROTOTYPES to CPPFLAGS for #ifdef's.
Fixed in tree now. Let me know if you know better fix for this.
...anyway, my initial comment was aimed at this particular package.
AC_HEADER_STDC is already called in configure.ac (and that macro already checks for string.h), so AFAICT, in this particular case, appending -DPROTOTYPES should be a safe solution.
(In reply to comment #16)
> I suppose there are no direct replacement for AM_C_PROTOTYPES, right?
There is no direct replacement, cause unless the upstream was relying on side effects of that macro, its only effect outside automake was "-DPROTOTYPES -D__PROTOTYPES", with the second definition used rarely ever.
Then just say you checked it already next time — it didn't appear the case (you said "standard solution", but the only way you have a standard solution is using an idempotent replacement).
uh hu, guys, I completely missed this bug already had a discussion about it (expected a boilerplate Comment #0 and that's it)
and of course I've checked all the C files for *PROTOTYPE*...
OK then :P
Well, I said "standard solution" cause it seems to me that *most* of AC_C_PROTOTYPES users didn't really know why did they use it in the first place, so *usually* "-DPROTOTYPES" does suffice.
WILL YOU STOP REOPENING THE BUG? Samuli fixed it.
(In reply to comment #22)
> WILL YOU STOP REOPENING THE BUG? Samuli fixed it.
sorry, accident, most of the times, that bugzilla warning is a false positive, so I tend to ignore it