Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 421671 - app-editors/nvi: db44 patch is half-broken
Summary: app-editors/nvi: db44 patch is half-broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jesus Rivero (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: db:5.x
  Show dependency tree
 
Reported: 2012-06-17 22:39 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2012-08-27 15:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2012-06-17 22:39:47 UTC
I fixed the QA notices on the patches with ../ in them since I saw it on the tinderbox. On the other hand I'd like for you to review/fix the db44 patch which has broken logic:

major >= 4 minor >= 4

will hit 4.4, 4.[5-9], 5.[4-9], 6.[4-9]

else major >= 1 minor >=1

will hit 4.[1-3], 5.[1-3], 6.[1-3]

what you want is

(major == 4 && minor >= 4) || major > 4
else major == 4 && minor >= 1

which will do what you expect.
Comment 1 Jesus Rivero (RETIRED) gentoo-dev 2012-08-27 15:48:40 UTC
This one was just pushed to the tree. 
Thanks Diego.