Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 417865 - autotools.eclass: please provide a way to call more utilities in eautoreconf
Summary: autotools.eclass: please provide a way to call more utilities in eautoreconf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 416933 416967
  Show dependency tree
 
Reported: 2012-05-27 20:19 UTC by Michał Górny
Modified: 2012-06-06 17:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Support gtk-doc & gnome-doc (0001-Support-calling-gtkdocize-gnome-doc-prepare.patch,1.61 KB, patch)
2012-05-31 13:12 UTC, Michał Górny
Details | Diff
Updated patch (0001-Support-calling-tools-handled-by-gnome-autogen.sh.patch,2.65 KB, patch)
2012-06-02 07:56 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-05-27 20:19:03 UTC
Since eautoreconf now seems to use saner code for utility handling, could you provide a way to inject calling more utilities like glib-gettextize or gtkdocize there?
Comment 1 SpanKY gentoo-dev 2012-05-30 22:21:36 UTC
why not post a patch to add them to the eclass ?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-05-31 05:48:37 UTC
(In reply to comment #1)
> why not post a patch to add them to the eclass ?

Will do. Following the suit of current utilities?
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-05-31 13:12:55 UTC
Created attachment 313717 [details, diff]
Support gtk-doc & gnome-doc
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-05-31 13:18:13 UTC
I'm not sure how to handle glib-gettext. Supposedly macro expansion can cause to both AM_GLIB_GNU_GETTEXT & AM_GNU_GETTEXT being declared. gnome-doc-prepare uses 'if; else' block to ensure that glib-gettextize is used instead of autopoint in that case.
Comment 5 SpanKY gentoo-dev 2012-06-01 21:31:39 UTC
you could add a new egettext helper that would take care of calling glib-gettextize or autopoint, and then rewrite the _at_uses_gettext to do a bit more work
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-06-02 07:56:36 UTC
Created attachment 313917 [details, diff]
Updated patch

Well, AFAICS that 'or' was just to avoid looking for two macros. This one should work fine.
Comment 7 SpanKY gentoo-dev 2012-06-06 05:05:29 UTC
Comment on attachment 313917 [details, diff]
Updated patch

looks ok.  let's merge it and see what blows up.  might want to drop a note to gentoo-dev to give people a heads up ;).
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-06-06 17:19:17 UTC
Committed.