Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 417117 - games-action/cs2d: Binary file cs2d.png in gentoo-x86
Summary: games-action/cs2d: Binary file cs2d.png in gentoo-x86
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Maxim Koltsov (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: binaries-in-git
  Show dependency tree
 
Reported: 2012-05-22 15:15 UTC by Samuli Suominen (RETIRED)
Modified: 2012-05-30 09:06 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2012-05-22 15:15:06 UTC
.png is a binary format, such files are not allowed in the gentoo-x86 tree, see bug 331331
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2012-05-22 15:17:42 UTC
The ebuild looks to be in a bit poor shape too:

1. Was this reviewed at #gentoo-games and accepted for commit?
2. Why is games@ missing from metadata.xml?

Please familiarize yourself with this document:

http://dev.gentoo.org/~vapier/i-wanna-be-in-the-games-herd.html
Comment 2 Julian Ospald 2012-05-22 21:53:22 UTC
As far as I am informed you don't need review if you don't add the games herd to metadata.xml, but then you cannot expect them to participate in maintainenance.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2012-05-23 08:14:40 UTC
I suppose I can file a separate bug for each problem in the ebuild, but that just seems a lot of unnecessary work and getting it reviewed would be a lot easier.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2012-05-25 23:15:01 UTC
Last time I checked, games should always have games@gentoo.org in metadata.xml
Comment 5 Julian Ospald 2012-05-25 23:27:18 UTC
I myself always go through #gentoo-games and people there are relatively responsive, but I don't see an official note that this is a REQUIREMENT. Was there a council vote or something? Maintaining a single package completely on your own should be allowed afaik. Plz correct me if this is wrong.

Also: http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1
this says it IS allowed to add .png if you use "cvs add -kb myphoto.png". If this is not correct then it's a documentation bug.

However I would also suggest to drop by at #gentoo-games to work with the games herd. More maintainers/eyes means higher quality.
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2012-05-25 23:58:01 UTC
(In reply to comment #5)
> I myself always go through #gentoo-games and people there are relatively
> responsive, but I don't see an official note that this is a REQUIREMENT. Was
> there a council vote or something? Maintaining a single package completely
> on your own should be allowed afaik. Plz correct me if this is wrong.
> 
> Also:
> http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1
> this says it IS allowed to add .png if you use "cvs add -kb myphoto.png". If
> this is not correct then it's a documentation bug.
> 
> However I would also suggest to drop by at #gentoo-games to work with the
> games herd. More maintainers/eyes means higher quality.

Err this is not something Council has to deal with. The council does not interferes with projects. However, I remember people saying that games@ must have explicit control over the games ebuilds. If this is not the case anymore then I apologize.

And yes, the documentation is wrong. binary files must not be allowed in portage. Feel free to open a new bug about that and attach a patch so we can fix it
Comment 7 Tim Harder gentoo-dev 2012-05-26 01:04:02 UTC
(In reply to comment #5)
> Also:
> http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1
> this says it IS allowed to add .png if you use "cvs add -kb myphoto.png". If
> this is not correct then it's a documentation bug.

If you read the lines closely it says "you should not add binary files to the Portage CVS tree" and then gives the option you mention when doing so for other CVS repos.

To me this means no binary files in the Portage tree, but they are allowed in other Gentoo CVS repos such as gentoo/misc/dev-pics. It could be clarified better though.
Comment 8 Julian Ospald 2012-05-26 01:06:42 UTC
(In reply to comment #7)
> (In reply to comment #5)
> > Also:
> > http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1
> > this says it IS allowed to add .png if you use "cvs add -kb myphoto.png". If
> > this is not correct then it's a documentation bug.
> 
> If you read the lines closely it says "you should not add binary files to
> the Portage CVS tree" and then gives the option you mention when doing so
> for other CVS repos.
> 
> To me this means no binary files in the Portage tree, but they are allowed
> in other Gentoo CVS repos such as gentoo/misc/dev-pics. It could be
> clarified better though.

for that discussion I opened: https://bugs.gentoo.org/show_bug.cgi?id=417535
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2012-05-26 06:31:30 UTC
The current documentation is very clear on the "If you need to do this in another CVS tree" -part, it has no room for confusion
Comment 10 Maxim Koltsov (RETIRED) gentoo-dev 2012-05-30 09:06:40 UTC
Fixed by move of png to mirrors.