Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 415805 - mozcoreconf-2 eclass should filter MOZCONFIG env variable in moz_pkgsetup()
Summary: mozcoreconf-2 eclass should filter MOZCONFIG env variable in moz_pkgsetup()
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Mozilla Gentoo Team
Depends on:
Reported: 2012-05-13 21:58 UTC by Julian Simioni
Modified: 2013-08-26 22:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Patch to filter MOZCONFIG (filterMOZCONFIG.patch,271 bytes, text/plain)
2012-05-24 01:55 UTC, Julian Simioni

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Simioni 2012-05-13 21:58:06 UTC
If doing development on any of the Mozilla applications, it's possible a user will set the MOZCONFIG[1] environmental variable to use their own developer settings. 
Even if no special settings are configured, the mere existence of this env var, if picked up during a compile of an ebuild such as Firefox or Thunderbird, can affect the result. In my case it simply caused Firefox to use the "Nightly" branding, but this is still undesirable.

Filtering MOZCONFIG in moz_pkgsetup() should eliminate any chance of this happening.

[1] Example of how MOZCONFIG is used:
Comment 1 Julian Simioni 2012-05-24 01:55:40 UTC
Created attachment 312909 [details]
Patch to filter MOZCONFIG

To speed things along, here's a patch that I tested in an overlay. It successfully ensures that firefox builds in a "clean" environment regardless of user env settings.
Comment 2 Jory A. Pratt gentoo-dev 2013-08-26 14:40:38 UTC
Thanks for reporting. I have pushed to overlay, and tree.
Comment 3 Arfrever Frehtes Taifersar Arahesis 2013-08-26 22:21:30 UTC
eval is not needed here.