Bug 412907 – x11-libs/libdrm: do not build tests that don't get installed

• Status: RESOLVED DUPLICATE of bug 300646
• Product: Gentoo Linux

[Description DaboD 2012-04-21 11:50:36 UTC]

[Comment 1 DaboD 2012-04-21 11:51:27 UTC]

Created attachment 309713 [details]
Remove tests directory from been built if cross compiling

[Comment 2 Jeroen Roovers (RETIRED) 2012-04-23 19:07:12 UTC]

Comment on attachment 309713 [details]
Remove tests directory from been built if cross compiling

--- libdrm-2.4.33.ebuild        2012-03-29 14:24:24.000000000 +0200
+++ -   2012-04-23 21:07:00.598853858 +0200
@@ -3,7 +3,7 @@
 # $Header: /var/cvsroot/gentoo-x86/x11-libs/libdrm/libdrm-2.4.33.ebuild,v 1.1 2012/03/29 12:24:24 chithanh Exp $
 
 EAPI=4
-inherit xorg-2
+inherit xorg-2 toolchain-funcs
 
 EGIT_REPO_URI="git://anongit.freedesktop.org/git/mesa/drm"
 
@@ -47,9 +47,10 @@
 }
 
 src_prepare() {
-       if [[ ${PV} = 9999* ]]; then
+       if [[ ${PV} = 9999* ]] || tc-is-cross-compiler; then
                # tests are restricted, no point in building them
                sed -ie 's/tests //' "${S}"/Makefile.am
+               XORG_EAUTORECONF=yes
        fi
        xorg-2_src_prepare
 }

[Comment 3 Matt Turner 2012-04-23 22:52:07 UTC]

I don't think there's any value to building the test directory at all, since we've restricted tests. I'll handle this when I get a chance if no one beats me to it.

[Comment 4 Chí-Thanh Christopher Nguyễn 2012-04-23 22:55:41 UTC]

Removing the build directory from Makefile.am makes eautoreconf run necessary, which negates any speedup from doing so.

[Comment 5 Matt Turner 2012-04-24 03:01:18 UTC]

(In reply to comment #4)
> Removing the build directory from Makefile.am makes eautoreconf run
> necessary, which negates any speedup from doing so.

Right. I think we can continue modifying Makefile.am for the 9999 ebuild and modify the generated Makefile for the others.

[Comment 6 SpanKY 2015-03-20 08:05:28 UTC]

probably want to change noinst_PROGRAMS to check_PROGRAMS in tests/

[Comment 7 SpanKY 2015-03-20 08:11:45 UTC]

*** This bug has been marked as a duplicate of bug 300646 ***