Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 412035 - media-libs/sdl-mixer: Make Timidity default and warn about FluidSynth
Summary: media-libs/sdl-mixer: Make Timidity default and warn about FluidSynth
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL: http://www.libsdl.org/projects/SDL_mi...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-04-14 22:18 UTC by James Le Cuirot
Modified: 2012-04-17 20:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against sdl-mixer-1.2.12.ebuild (sdl-mixer-ebuild.patch,1.08 KB, patch)
2012-04-14 22:18 UTC, James Le Cuirot
Details | Diff
Second patch against sdl-mixer-1.2.12.ebuild (sdl-mixer-midi.patch,1.34 KB, patch)
2012-04-17 08:35 UTC, James Le Cuirot
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Le Cuirot gentoo-dev 2012-04-14 22:18:09 UTC
Created attachment 308983 [details, diff]
Patch against sdl-mixer-1.2.12.ebuild

FluidSynth support was added to SDL_mixer as of 1.2.12. I implemented this myself. :) The ebuild has already been updated accordingly (thanks!) but there is potential for users to get caught out. Because FluidSynth requires a SoundFont and none are automatically provided, this support doesn't quite work out of the box. Failing to set SDL_SOUNDFONTS to something valid will either result in Timidity being used or silence if Timidity support is missing. For this reason, a pkg_postinst warning should be added and the timidity USE flag should be enabled by default. Please see the attached patch.
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2012-04-17 05:37:06 UTC
added the warning.  No default use flag though - that would pull in timidity for a lot of people who previously didn't care at all about anything midi-related (like me).
Comment 2 James Le Cuirot gentoo-dev 2012-04-17 08:35:06 UTC
Created attachment 309229 [details, diff]
Second patch against sdl-mixer-1.2.12.ebuild

Thanks for that. What if you wrap the dependencies in midi like so?
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2012-04-17 14:46:15 UTC
i can dig it.
Comment 4 James Le Cuirot gentoo-dev 2012-04-17 20:04:37 UTC
Great. Just one problem, I forgot to put IUSE="+timidity" in that second patch and you didn't notice either. :(