Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 410603 - sys-auth/polkit-qt - pkg-config file reports incorrect includes for --cflags
Summary: sys-auth/polkit-qt - pkg-config file reports incorrect includes for --cflags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL: https://git.reviewboard.kde.org/r/114...
Whiteboard: tracking upstream
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 21:17 UTC by Julian Ospald
Modified: 2014-07-22 13:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
polkit-qt-0.103.0-pkgconfig.patch (polkit-qt-0.103.0-pkgconfig.patch,3.44 KB, patch)
2013-12-28 19:59 UTC, Julian Ospald 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2012-04-02 21:17:30 UTC 
# pkg-config --cflags polkit-qt-1
-DQT_SHARED -I/usr/include/qt4 -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtGui

Shouldn't this be:
/usr/include/polkit-qt-1 and it's subdirs?

Version:
# pkg-config --modversion polkit-qt-1
0.103.0
# pkg-config --version
0.26
Comment 1 Julian Ospald 2013-12-27 22:30:33 UTC 
meh, despite that I have a very strong opinion about modifying pkgconfig files downstream... should we just fix this? The bug has been open long enough upstream.
Comment 2 Michael Palimaka (kensington) gentoo-dev 2013-12-28 14:54:47 UTC 
I am not particularly familiar with pkgconfig file generation. If you know how to fix the issue "correctly", I can integrate the changes upstream directly.
Comment 3 Julian Ospald 2013-12-28 19:59:34 UTC 
Created attachment 366388 [details, diff]
polkit-qt-0.103.0-pkgconfig.patch

please review


# for i in "" "-agent" "-core" "-gui" ; do pkg-config --libs polkit-qt${i}-1 ; done
-L/usr/lib64/qt4 -lpolkit-qt-gui-1 -lpolkit-qt-core-1 -lpolkit-qt-agent-1 -lQtGui -lQtCore 
-L/usr/lib64/qt4 -lpolkit-qt-agent-1 -lQtGui -lQtCore 
-L/usr/lib64/qt4 -lpolkit-qt-core-1 -lQtCore 
-L/usr/lib64/qt4 -lpolkit-qt-gui-1 -lQtGui -lpolkit-qt-core-1 -lQtCore 

# for i in "" "-agent" "-core" "-gui" ; do pkg-config --cflags polkit-qt${i}-1 ; done
-DQT_SHARED -I/usr/include/polkit-qt-1 -I/usr/include/qt4 -I/usr/include/qt4/QtGui -I/usr/include/qt4 -I/usr/include/qt4/QtCore 
-DQT_SHARED -I/usr/include/polkit-qt-1 -I/usr/include/qt4 -I/usr/include/qt4/QtGui -I/usr/include/qt4 -I/usr/include/qt4/QtCore 
-DQT_SHARED -I/usr/include/polkit-qt-1 -I/usr/include/qt4 -I/usr/include/qt4/QtCore 
-DQT_SHARED -I/usr/include/polkit-qt-1 -I/usr/include/qt4 -I/usr/include/qt4/QtGui -I/usr/include/polkit-qt-1 -I/usr/include/qt4 -I/usr/include/qt4/QtCore 

# pkg-config --variable=polkit_policy_files_install_dir polkit-qt-1
/usr/share/polkit-1/actions
Comment 4 Julian Ospald 2014-03-17 18:22:07 UTC 
so?
Comment 5 Michael Palimaka (kensington) gentoo-dev 2014-03-21 16:29:19 UTC 
still waiting for upstream
Comment 6 Michael Palimaka (kensington) gentoo-dev 2014-07-22 13:39:14 UTC 
This is fixed in polkit-qt-0.112.0, except for the variable=polkit_policy_files_install_dir thing. If that's still needed let us know and we can follow up again.