Bug 409955 – Print qawarn if -Werror is found during emake phase

• Status: RESOLVED DUPLICATE of bug 384193
• Product: Portage Development

[Description Tomáš Chvátal (RETIRED) 2012-03-28 07:47:36 UTC]

Hi,
as per summary please make emake detect -Werror in cflags/cxxflags and spew qa warning about it.

Even if we won't catch all the scenarios it will improve the current situation where maintainers commit packages that contain Werror in them without checking.

Cheers

[Comment 1 Fabian Groffen 2012-03-28 07:52:41 UTC]

would be nice if buildsystems would default to verbose output then...

[Comment 2 Tomáš Chvátal (RETIRED) 2012-03-28 07:58:54 UTC]

Probably yes, for both cmake and autotools it should be done by "make V=1"

[Comment 3 Zac Medico 2012-03-28 17:16:29 UTC]

The way that a check like this works is to search the build log, so is it okay if we just search the whole build log, rather than try to limit it to emake calls?

(In reply to comment #2)
> Probably yes, for both cmake and autotools it should be done by "make V=1"

Should that that V=1 argument come after ${EXTRA_EMAKE}, in order to override it? Does this mean that we no longer support arguments that make it quiet? That's fine with me. I guess people can use emerge --quiet-build if they want things more quiet.

[Comment 4 Fabian Groffen 2012-03-28 17:59:41 UTC]

I was referring to a bug I opened long ago against cmake eclass.  That was turned down because devs were against "non-pretty" output.  See also
http://archives.gentoo.org/gentoo-dev/msg_a4907093258ecf3ec385814eced672d9.xml

I'm all for squashing that with --quiet-build=y, though.

[Comment 5 Zac Medico 2012-05-05 08:03:53 UTC]

To quote bug #379497, comment #8, "adding random V=1 to MAKEOPTS is known to break builds which use V for something else."

[Comment 6 Zac Medico 2012-05-05 08:25:00 UTC]

*** This bug has been marked as a duplicate of bug 384193 ***