Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 408305 - qt-mobility-1.2 does not build with >=x11-libs/qt-core-4.8
Summary: qt-mobility-1.2 does not build with >=x11-libs/qt-core-4.8
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-15 10:09 UTC by Corentin Chary (RETIRED)
Modified: 2012-04-04 16:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
qt-mobility-1.2.0-respect-QT_NO_XVIDEO.patch (qt-mobility-1.2.0-respect-QT_NO_XVIDEO.patch,788 bytes, patch)
2012-03-15 10:10 UTC, Corentin Chary (RETIRED)
Details | Diff
qt-mobility-1.2.0-ipc-fix-metacall-proto.patch (qt-mobility-1.2.0-ipc-fix-metacall-proto.patch,816 bytes, patch)
2012-03-15 10:10 UTC, Corentin Chary (RETIRED)
Details | Diff
qt-mobility-1.2.0.ebuild (qt-mobility-1.2.0.ebuild,4.46 KB, text/plain)
2012-03-15 10:10 UTC, Corentin Chary (RETIRED)
Details
qmetaobjectbuilder-qt48.patch (qmetaobjectbuilder-qt48.patch,277.69 KB, patch)
2012-03-27 23:55 UTC, Davide Pesavento (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Corentin Chary (RETIRED) gentoo-dev 2012-03-15 10:09:46 UTC
Upstream bug is here: https://bugreports.qt-project.org/browse/QTMOBILITY-1990?focusedCommentId=170231&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel

qt-mobility-1.2 was released with Qt 4.7 and was not updated for 4.8 . The git tree is fixed but an official release is unlikely to happen before Qt 5.
Comment 1 Corentin Chary (RETIRED) gentoo-dev 2012-03-15 10:10:05 UTC
Created attachment 305461 [details, diff]
qt-mobility-1.2.0-respect-QT_NO_XVIDEO.patch
Comment 2 Corentin Chary (RETIRED) gentoo-dev 2012-03-15 10:10:17 UTC
Created attachment 305463 [details, diff]
qt-mobility-1.2.0-ipc-fix-metacall-proto.patch
Comment 3 Corentin Chary (RETIRED) gentoo-dev 2012-03-15 10:10:42 UTC
Created attachment 305465 [details]
qt-mobility-1.2.0.ebuild
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2012-03-15 15:14:17 UTC
Comment on attachment 305465 [details]
qt-mobility-1.2.0.ebuild

--- qt-mobility-1.2.0.ebuild    2011-11-11 00:16:04.000000000 +0100
+++ -   2012-03-15 16:13:28.560121050 +0100
@@ -4,7 +4,7 @@
 
 EAPI=4
 
-inherit multilib qt4-r2
+inherit eutils multilib qt4-r2
 
 MY_P="${PN}-opensource-src-${PV}"
 
@@ -128,6 +128,12 @@
        if ! use qml; then
                sed -i -e '/SUBDIRS += declarative/d' plugins/plugins.pro || die
        fi
+
+       if has_version ">=x11-libs/qt-core-4.8.0"; then
+               epatch "${FILESDIR}"/${P}-ipc-fix-metacall-proto.patch
+       fi
+
+       epatch "${FILESDIR}"/${P}-respect-QT_NO_XVIDEO.patch
 }
 
 src_configure() {


Patches shouldn't be applied conditionally...
Comment 5 Davide Pesavento (RETIRED) gentoo-dev 2012-03-15 15:40:04 UTC
I suppose both patches are taken from upstream git repo..?
Comment 6 Corentin Chary (RETIRED) gentoo-dev 2012-03-15 16:18:19 UTC
(In reply to comment #4)
> Comment on attachment 305465 [details]
> qt-mobility-1.2.0.ebuild
> 
> --- qt-mobility-1.2.0.ebuild    2011-11-11 00:16:04.000000000 +0100
> +++ -   2012-03-15 16:13:28.560121050 +0100
> @@ -4,7 +4,7 @@
>  
>  EAPI=4
>  
> -inherit multilib qt4-r2
> +inherit eutils multilib qt4-r2
>  
>  MY_P="${PN}-opensource-src-${PV}"
>  
> @@ -128,6 +128,12 @@
>         if ! use qml; then
>                 sed -i -e '/SUBDIRS += declarative/d' plugins/plugins.pro ||
> die
>         fi
> +
> +       if has_version ">=x11-libs/qt-core-4.8.0"; then
> +               epatch "${FILESDIR}"/${P}-ipc-fix-metacall-proto.patch
> +       fi
> +
> +       epatch "${FILESDIR}"/${P}-respect-QT_NO_XVIDEO.patch
>  }
>  
>  src_configure() {
> 
> 
> Patches shouldn't be applied conditionally...

Then you can always apply a patch that checks QT_VERSION and use the old prototype for < 4.7.
Comment 7 Corentin Chary (RETIRED) gentoo-dev 2012-03-15 16:19:16 UTC
(In reply to comment #5)
> I suppose both patches are taken from upstream git repo..?

Kind of. I took a look at the current git tree and extracted what was needed to make it work.
Comment 8 Giorgos Tsiapaliwkas 2012-03-27 19:22:06 UTC
Hello,

Do you intend to add the patch in the tree?
Comment 9 Davide Pesavento (RETIRED) gentoo-dev 2012-03-27 20:46:35 UTC
(In reply to comment #8)
> Hello,
> 
> Do you intend to add the patch in the tree?

I'm working on it.
Comment 10 Davide Pesavento (RETIRED) gentoo-dev 2012-03-27 23:55:31 UTC
Created attachment 306913 [details, diff]
qmetaobjectbuilder-qt48.patch

Try this patch please.
(extracted from upstream commits in the range b90cee3d3502c20f9dda5d90c305afd5a046552c^..f9c87a7e68fac52ed92c430b2360827438f2e33b)
Comment 11 Davide Pesavento (RETIRED) gentoo-dev 2012-03-27 23:59:40 UTC
The xvideo-related failure is caused by a bug in qt-gui, so please be sure to update to >=x11-libs/qt-gui-4.8.0-r4 before trying the above patch.
Comment 12 Corentin Chary (RETIRED) gentoo-dev 2012-03-28 06:09:20 UTC
If you import a patch as big as that, I honestly think it would be better to create a snapshot ebuild that only works with 4.8 and keep the current one for 4.7.
Comment 13 Davide Pesavento (RETIRED) gentoo-dev 2012-03-28 09:59:33 UTC
I disagree. The patch is conceptually very simple, it does a few copies and renames, that's why it is big in size.

Anyway, the xvideo fix really requires >=qt-gui-4.8.0-r4[xv], thus I'm considering doing a snapshot ebuild with raised deps anyway, for that reason.
Comment 14 Corentin Chary (RETIRED) gentoo-dev 2012-03-28 11:52:38 UTC
As long as I got somethink that builds with 4.8 I'm happy. Thanks !
Comment 15 Giorgos Tsiapaliwkas 2012-03-28 12:43:51 UTC
I think that a revision will be the best solution
Comment 16 Giorgos Tsiapaliwkas 2012-04-01 17:26:23 UTC
what's the status on this bug?
Today I tried to reemerge qt-mobility and it still fails.
Comment 17 Davide Pesavento (RETIRED) gentoo-dev 2012-04-01 18:01:00 UTC
(In reply to comment #16)
> what's the status on this bug?
> Today I tried to reemerge qt-mobility and it still fails.

I'm working on it, I've found some additional issues that needs fixing.
Comment 18 Davide Pesavento (RETIRED) gentoo-dev 2012-04-04 16:19:00 UTC
Fixed in qt-mobility-1.2.2_p20120403. Dependencies in 1.2.0 have been restricted to 4.7.x. Thank you all!