Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 407445 - sys-apps/kexec-tools-2.0.2-r1 prints unnecessary message on stderr when loaded in VESA framebuffer
Summary: sys-apps/kexec-tools-2.0.2-r1 prints unnecessary message on stderr when loade...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Justin Lecher (RETIRED)
URL: http://lists.infradead.org/pipermail/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-08 16:57 UTC by Maxim Kammerer
Modified: 2013-08-20 22:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Kammerer 2012-03-08 16:57:33 UTC
In kexec/arch/i386/x86-linux-setup.c:setup_linux_vesafb():

    fprintf(stderr, "%s: %dx%dx%d @ %lx +%x\n", __FUNCTION__,
        var.xres, var.yres, var.bits_per_pixel,
        fix.smem_start, fix.smem_len);

This message is pretty annoying (especially if kexec is loaded several times with different parameters during startup/shutdown). Looking in that source file, that's the only fprintf which is not an error.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2012-03-08 17:03:06 UTC
Could you please report this to upstream and leave to reference here?
Comment 2 Maxim Kammerer 2012-03-08 17:30:50 UTC
Reported: http://lists.infradead.org/pipermail/kexec/2012-March/006148.html
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2012-03-08 18:05:24 UTC
Thanks for that.
Comment 4 Maxim Kammerer 2012-03-13 00:58:11 UTC
This will be fixed in the next release (i would link to the mailing list message, but the archive server has been down all day):

======================================================
Agreed, I have pushed the following patch into
the kexec-tools git tree and it should be included in
the next release.


From f1facd4b11aa141ffd9bbacb2631ad18dc33669c Mon Sep 17 00:00:00 2001
From: Simon Horman <horms@verge.net.au>
Date: Mon, 12 Mar 2012 15:01:35 +0900
Subject: [PATCH] i386: Don't print debug message when VESA framebuffer is
 loaded

This messages seems unnecessarily verbose.

Reported-by: Maxim Kammerer <mk@dee.su>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
 kexec/arch/i386/x86-linux-setup.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c
index 0528cea..08d64ca 100644
--- a/kexec/arch/i386/x86-linux-setup.c
+++ b/kexec/arch/i386/x86-linux-setup.c
@@ -151,9 +151,6 @@ int setup_linux_vesafb(struct x86_linux_param_header *real_mode)
               real_mode->rsvd_pos   = var.transp.offset;
               real_mode->rsvd_size  = var.transp.length;
       }
-       fprintf(stderr, "%s: %dx%dx%d @ %lx +%x\n", __FUNCTION__,
-               var.xres, var.yres, var.bits_per_pixel,
-               fix.smem_start, fix.smem_len);
       return 0;

 out:
======================================================
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2012-03-13 06:36:55 UTC
Cool,

thans for your efforts. I will keep my eyes open and bump ASAP.